Sign upLogin

osbridge/openconferenceware

View on GitHub
Star
app/controllers/open_conference_ware/proposals_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

File proposals_controller.rb has 413 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module OpenConferenceWare
  class ProposalsController < ApplicationController

    before_filter :authentication_required, only: [:edit, :update, :destroy, :speaker_confirm, :speaker_decline, :proposal_login_required]
    before_filter :assert_current_event_or_redirect
Severity: Minor
Found in app/controllers/open_conference_ware/proposals_controller.rb - About 5 hrs to fix

    Class ProposalsController has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class ProposalsController < ApplicationController

    before_filter :authentication_required, only: [:edit, :update, :destroy, :speaker_confirm, :speaker_decline, :proposal_login_required]
    before_filter :assert_current_event_or_redirect
    before_filter :assert_proposal_status_published, only: [:sessions_index, :sessions_index_terse, :session_show]
    Severity: Minor
    Found in app/controllers/open_conference_ware/proposals_controller.rb - About 3 hrs to fix

      Method update has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          def update
      # @proposal and @event set via #assign_proposal_and_event filter

      # If proposal title editing is locked, prevent non-admin from modifying title.
      if params[:proposal] && @event.proposal_titles_locked? && ! admin?
      Severity: Minor
      Found in app/controllers/open_conference_ware/proposals_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method index has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def index
      warn_about_incomplete_event

      @kind = :proposals
      Severity: Minor
      Found in app/controllers/open_conference_ware/proposals_controller.rb - About 1 hr to fix

        Method update has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def update
      # @proposal and @event set via #assign_proposal_and_event filter

      # If proposal title editing is locked, prevent non-admin from modifying title.
      if params[:proposal] && @event.proposal_titles_locked? && ! admin?
        Severity: Minor
        Found in app/controllers/open_conference_ware/proposals_controller.rb - About 1 hr to fix

          Method index has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              def index
      warn_about_incomplete_event

      @kind = :proposals
          Severity: Minor
          Found in app/controllers/open_conference_ware/proposals_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method base_show has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def base_show
      if selector? && @event.accept_selector_votes?
        @selector_vote = @proposal.selector_votes.find_or_initialize_by(user_id: current_user.id)
      end
          Severity: Minor
          Found in app/controllers/open_conference_ware/proposals_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method base_show has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def base_show
      if selector? && @event.accept_selector_votes?
        @selector_vote = @proposal.selector_votes.find_or_initialize_by(user_id: current_user.id)
      end
          Severity: Minor
          Found in app/controllers/open_conference_ware/proposals_controller.rb - About 1 hr to fix

            Method create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def create
      @proposal = @event.proposals.new(proposal_params)
      @proposal.add_user(current_user) if logged_in?
      @proposal.transition = transition_from_params if admin?
            Severity: Minor
            Found in app/controllers/open_conference_ware/proposals_controller.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method get_proposal_and_assignment_status has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def get_proposal_and_assignment_status
      if proposal = Proposal.find(params[:id].to_i) rescue nil
        if proposal.event
          return [proposal, :assigned_via_param]
        else
            Severity: Minor
            Found in app/controllers/open_conference_ware/proposals_controller.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method assert_accepting_proposals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def assert_accepting_proposals
      unless accepting_proposals? || admin?
        flash[:failure] = Snippet.content_for(:proposals_not_accepted_error)
        redirect_to @event ? event_proposals_path(@event) : proposals_path
      end
            Severity: Minor
            Found in app/controllers/open_conference_ware/proposals_controller.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      @proposal.valid? if params[:preview]
          format.html { render action: "new" }
          format.xml  { render xml: @proposal.errors, status: :unprocessable_entity }
          format.json { render json: @proposal.errors, status: :unprocessable_entity }
            Severity: Minor
            Found in app/controllers/open_conference_ware/proposals_controller.rb and 1 other location - About 35 mins to fix
            app/controllers/open_conference_ware/proposals_controller.rb on lines 273..277

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 34.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      @proposal.valid? if params[:preview]

          format.html { render action: "edit" }
          format.xml  { render xml: @proposal.errors, status: :unprocessable_entity }
          format.json { render json: @proposal.errors, status: :unprocessable_entity }
            Severity: Minor
            Found in app/controllers/open_conference_ware/proposals_controller.rb and 1 other location - About 35 mins to fix
            app/controllers/open_conference_ware/proposals_controller.rb on lines 222..225

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 34.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status