Sign upLogin

osbridge/openconferenceware

View on GitHub
Star
app/models/open_conference_ware/proposal.rb

Summary

Maintainability
D
2 days
Test Coverage

File proposal.rb has 460 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module OpenConferenceWare

  # == Schema Information
  #
  # Table name: proposals
Severity: Minor
Found in app/models/open_conference_ware/proposal.rb - About 7 hrs to fix

    Class Proposal has 48 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Proposal < OpenConferenceWare::Base
    # Provide ::validate_url_attribute
    include NormalizeUrlMixin

    # Provide ::event_tracks? and other methods for accessing SETTING
    Severity: Minor
    Found in app/models/open_conference_ware/proposal.rb - About 6 hrs to fix

      Method to_icalendar has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.to_icalendar(items, opts={})
      title = opts[:title] || "Schedule"
      url_helper = opts[:url_helper]

      calendar = Vpim::Icalendar.create2(Vpim::PRODID)
      Severity: Minor
      Found in app/models/open_conference_ware/proposal.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method to_icalendar has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.to_icalendar(items, opts={})
      title = opts[:title] || "Schedule"
      url_helper = opts[:url_helper]

      calendar = Vpim::Icalendar.create2(Vpim::PRODID)
      Severity: Minor
      Found in app/models/open_conference_ware/proposal.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def notify_rejected_speakers
      if rejected?
        if !notified_at
          SpeakerMailer.speaker_rejected_email(self).deliver
          self.notified_at = Time.now
        Severity: Minor
        Found in app/models/open_conference_ware/proposal.rb and 1 other location - About 30 mins to fix
        app/models/open_conference_ware/proposal.rb on lines 621..632

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def notify_accepted_speakers
      if accepted?
        if !notified_at
          SpeakerMailer.speaker_accepted_email(self).deliver
          self.notified_at = Time.now
        Severity: Minor
        Found in app/models/open_conference_ware/proposal.rb and 1 other location - About 30 mins to fix
        app/models/open_conference_ware/proposal.rb on lines 636..647

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status