Sign upLogin

osbzr/gooderp_addons

View on GitHub
Star
auto_exchange/models/auto_exchange.py

Summary

Maintainability
A
1 hr
Test Coverage

Function get_exchange has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def get_exchange(self):
        '''当设置自动运行时，传来的self为空值，需要补全所需自动运行的那几个ids'''
        if not self:
            currency_ids = self.env['res.currency'].search(
                [('active', '=', True)])
Severity: Minor
Found in auto_exchange/models/auto_exchange.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _compute_current_rate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def _compute_current_rate(self):
        date = self._context.get('date') or fields.Datetime.now()
        period_id = self.env['finance.period'].get_period(date).id
        for currency in self:
            currency.rate = 1.0
Severity: Minor
Found in auto_exchange/models/auto_exchange.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line too long (86 > 79 characters)
Open

                if line.date <= fields.Date.context_today(self) and not line.exchange:
Severity: Minor
Found in auto_exchange/models/auto_exchange.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (141 > 79 characters)
Open

            'User-Agent': 'Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.6 Safari/537.36',
Severity: Minor
Found in auto_exchange/models/auto_exchange.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (81 > 79 characters)
Open

                    line.note = u'系统于(%s)从中国银行网站上取得' % fields.Date.context_today(
Severity: Minor
Found in auto_exchange/models/auto_exchange.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status