finance/wizard/checkout_wizard.py
Function button_checkout has a Cognitive Complexity of 123 (exceeds 5 allowed). Consider refactoring. Open
Open
def button_checkout(self):
''' 月末结账：结账 按钮 '''
for balance in self:
if balance.period_id:
if balance.period_id.is_closed:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function recreate_voucher_name has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring. Open
Open
def recreate_voucher_name(self, period_id):
# 取重排凭证设置
# 是否重置凭证号
context = dict(self.env.context or {})
context['call_module'] = "checkout_wizard"- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function button_counter_checkout has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
Open
def button_counter_checkout(self):
for balance in self:
if balance.period_id:
if not balance.period_id.is_closed:
raise UserError(u'期间%s未结账' % balance.period_id.name)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File checkout_wizard.py has 288 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
# -*- coding: utf-8 -*-
from odoo import models, fields, api
from odoo.exceptions import UserError
Avoid deeply nested control flow statements. Open
Open
if not remain_account:
raise UserError(u'公司未分配利润科目未配置')
if (revenue_total - expense_total) > 0:Avoid deeply nested control flow statements. Open
Open
for year_profit_id in year_profit_ids:
year_total += (year_profit_id.credit -
year_profit_id.debit)
precision = self.env['decimal.precision'].precision_get(Avoid deeply nested control flow statements. Open
Open
if balance.period_id.month == '12':
self.env['finance.period'].create({'year': str(int(balance.period_id.year) + 1),
'month': '1', })
else:
self.env['finance.period'].create({'year': balance.period_id.year,Avoid deeply nested control flow statements. Open
Open
for revenue_account_id in revenue_account_ids:
voucher_line_ids = voucher_line_obj.search([
('account_id', '=', revenue_account_id.id),
('voucher_id.period_id', '=', balance.period_id.id),
('state', '=', 'done')])Avoid deeply nested control flow statements. Open
Open
if year_total != 0:
year_line_ids = [{
'name': u'年度结余',
'account_id': remain_account.id,
'debit': 0,Avoid deeply nested control flow statements. Open
Open
if not year_profit_account:
raise UserError(u'公司本年利润科目未配置')
if not remain_account:Avoid deeply nested control flow statements. Open
Open
if period_id.year != last_period.year:
# 按年，而且是第一个会计期间
last_voucher_number = reset_init_number
else:
# 查找上一期间最后凭证号Avoid deeply nested control flow statements. Open
Open
if voucher_id.state != 'done':
draft_voucher_count += 1
if draft_voucher_count != 0:Avoid deeply nested control flow statements. Open
Open
if (revenue_total - expense_total) < 0:
res = {
'name': u'利润结余',
'account_id': year_profit_account.id,
'debit': expense_total - revenue_total,Avoid deeply nested control flow statements. Open
Open
for expense_account_id in expense_account_ids:
voucher_line_ids = voucher_line_obj.search([
('account_id', '=', expense_account_id.id),
('voucher_id.period_id', '=', balance.period_id.id),
('state', '=', 'done')])Avoid deeply nested control flow statements. Open
Open
if voucher_line:
valus = {
'is_checkout': True,
'date': self.date,
'line_ids': [Avoid deeply nested control flow statements. Open
Open
if (revenue_total - expense_total) > 0:
res = {
'name': u'利润结余',
'account_id': year_profit_account.id,
'debit': 0,Avoid deeply nested control flow statements. Open
Open
if not last_period.is_closed:
raise UserError(u'上一个期间%s未结账' % last_period.name)
if period_id.year != last_period.year:Avoid deeply nested control flow statements. Open
Open
if next_period.is_closed:
raise UserError(u'下一个期间%s已结账！' % next_period.name)
# 重新打开会计期间
balance.period_id.is_closed = FalseLine too long (93 > 79 characters) Open
Open
last_period = self.env['create.trial.balance.wizard'].compute_last_period_id(- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (113 > 79 characters) Open
Open
'month': str(int(balance.period_id.month) + 1), })- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (93 > 79 characters) Open
Open
debit_total += voucher_line_id.debit - voucher_line_id.credit- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (85 > 79 characters) Open
Open
year_profit_account = self.env.user.company_id.profit_account- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (87 > 79 characters) Open
Open
next_voucher_name = '%%0%sd' % seq_id.padding % last_voucher_number- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (84 > 79 characters) Open
Open
('voucher_id.period_id', '=', balance.period_id.id),- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (89 > 79 characters) Open
Open
# raise UserError(u'请核实上一个期间：%s是否有凭证！' % last_period.name)- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (80 > 79 characters) Open
Open
remain_account = self.env.user.company_id.remain_account- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (88 > 79 characters) Open
Open
s for s in seq_ids if s.company_id and s.company_id.id == force_company]- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (100 > 79 characters) Open
Open
[('period_id', '=', period_id.id), ('state', '=', 'done')], order='create_date')- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (94 > 79 characters) Open
Open
credit_total += voucher_line_id.credit - voucher_line_id.debit- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (100 > 79 characters) Open
Open
pre_period = self.env['create.trial.balance.wizard'].compute_last_period_id(- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (102 > 79 characters) Open
Open
filter(str.isdigit, last_period_voucher_name.encode("utf-8"))) + 1- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (87 > 79 characters) Open
Open
next_voucher_name = '%%0%sd' % seq_id.padding % last_voucher_number- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (105 > 79 characters) Open
Open
last_period = self.env['create.trial.balance.wizard'].compute_last_period_id(- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (84 > 79 characters) Open
Open
('voucher_id.period_id', '=', balance.period_id.id),- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (81 > 79 characters) Open
Open
(0, 0, line) for line in year_line_ids],- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (94 > 79 characters) Open
Open
self.env['finance.period'].create({'year': balance.period_id.year,- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (97 > 79 characters) Open
Open
next_period = self.env['create.trial.balance.wizard'].compute_next_period_id(- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (80 > 79 characters) Open
Open
precision = self.env['decimal.precision'].precision_get(- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (89 > 79 characters) Open
Open
voucher_ids = self.env['voucher'].search([('is_checkout', '=', True),- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (99 > 79 characters) Open
Open
('state', '=', 'done')],- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (100 > 79 characters) Open
Open
[('period_id', '=', period_id.id), ('state', '=', 'done')], order='create_date')- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (104 > 79 characters) Open
Open
('period_id', '=', balance.period_id.id)])- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (110 > 79 characters) Open
Open
last_period_voucher_name = voucher_obj.search([('period_id', '=', last_period.id),- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (83 > 79 characters) Open
Open
trial_wizard = self.env['create.trial.balance.wizard'].create({- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (97 > 79 characters) Open
Open
next_period = self.env['create.trial.balance.wizard'].compute_next_period_id(- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (83 > 79 characters) Open
Open
['&', ('code', '=', 'voucher'), ('company_id', 'in', company_ids)])- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (82 > 79 characters) Open
Open
seq_id = preferred_sequences[0] if preferred_sequences else seq_ids[0]- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (87 > 79 characters) Open
Open
('voucher_id.period_id.year', '=', balance.period_id.year),- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (108 > 79 characters) Open
Open
self.env['finance.period'].create({'year': str(int(balance.period_id.year) + 1),- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (89 > 79 characters) Open
Open
last_period = self.env['create.trial.balance.wizard'].compute_last_period_id(- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.Line too long (113 > 79 characters) Open
Open
order="create_date desc", limit=1).name- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side. The default wrapping on such
devices looks ugly. Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.
Reports error E501.