Sign upLogin

osbzr/gooderp_addons

View on GitHub
Star
partner_address/models/partner_address.py

Summary

Maintainability
C
1 day
Test Coverage

Function onchange_city has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    def onchange_city(self):
        # 为地址填写时方便，当选定市时 ，县区的列表里面只有所选市的
        if self.city_id:
            domain_dict = {'county_id': [('city_id', '=', self.city_id.id)]}
            province = self.city_id.province_id
Severity: Minor
Found in partner_address/models/partner_address.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onchange_province has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def onchange_province(self):
        # 为地址填写时方便，当选定省时 ，市区的列表里面只有所选省的
        if self.province_id:
            domain_dict = {'city_id': [
                ('province_id', '=', self.province_id.id)]}
Severity: Minor
Found in partner_address/models/partner_address.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _compute_partner_address has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def _compute_partner_address(self):
        '''如果业务伙伴地址中有默认地址，则显示在业务伙伴列表上'''
        if not self.child_ids:
            return {}
        for child in self.child_ids:
Severity: Minor
Found in partner_address/models/partner_address.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if self.county_id.city_id == self.city_id:
                            domain_dict = {}
                        else:
                            self.county_id = False
                else:
Severity: Major
Found in partner_address/models/partner_address.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if province != self.province_id:
                            self.province_id = province
                            self.county_id = False
                        else:
                            self.county_id = False
    Severity: Major
    Found in partner_address/models/partner_address.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if province != self.province_id:
                            self.province_id = province
                    else:
      Severity: Major
      Found in partner_address/models/partner_address.py - About 45 mins to fix

        Function name_get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def name_get(self):
        '''在many2one字段里显示 编号_名称'''
        res = []

        for adds in self:
        Severity: Minor
        Found in partner_address/models/partner_address.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _put_info_to_partner has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _put_info_to_partner(self, child):
        self.contact = child.contact
        self.mobile = child.mobile
        self.phone = child.phone
        self.qq = child.qq
        Severity: Minor
        Found in partner_address/models/partner_address.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Line too long (85 > 79 characters)
        Open

                address = '%s%s%s%s%s' % (child.province_id and child.province_id.name or '',
        Severity: Minor
        Found in partner_address/models/partner_address.py by pep8

        Limit all lines to a maximum of 79 characters.

        There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

        Line too long (82 > 79 characters)
        Open

                                          child.city_id and child.city_id.city_name or '',
        Severity: Minor
        Found in partner_address/models/partner_address.py by pep8

        Limit all lines to a maximum of 79 characters.

        There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

        Line too long (87 > 79 characters)
        Open

                    add_str = '%s%s%s%s%s' % (adds.province_id and adds.province_id.name or '',
        Severity: Minor
        Found in partner_address/models/partner_address.py by pep8

        Limit all lines to a maximum of 79 characters.

        There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

        Line too long (88 > 79 characters)
        Open

                                          child.county_id and child.county_id.county_name or '',
        Severity: Minor
        Found in partner_address/models/partner_address.py by pep8

        Limit all lines to a maximum of 79 characters.

        There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

        Line too long (159 > 79 characters)
        Open

            @api.depends('child_ids.is_default_add', 'child_ids.province_id', 'child_ids.city_id', 'child_ids.county_id', 'child_ids.town', 'child_ids.detail_address')
        Severity: Minor
        Found in partner_address/models/partner_address.py by pep8

        Limit all lines to a maximum of 79 characters.

        There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

        Line too long (92 > 79 characters)
        Open

                if self.county_id and self.county_id.city_id and self.county_id.city_id.province_id:
        Severity: Minor
        Found in partner_address/models/partner_address.py by pep8

        Limit all lines to a maximum of 79 characters.

        There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

        Line too long (84 > 79 characters)
        Open

                                              adds.city_id and adds.city_id.city_name or '',
        Severity: Minor
        Found in partner_address/models/partner_address.py by pep8

        Limit all lines to a maximum of 79 characters.

        There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

        Line too long (90 > 79 characters)
        Open

                                              adds.county_id and adds.county_id.county_name or '',
        Severity: Minor
        Found in partner_address/models/partner_address.py by pep8

        Limit all lines to a maximum of 79 characters.

        There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

        There are no issues that match your filters.

        Category
        Status