Sign upLogin

osbzr/gooderp_addons

View on GitHub
Star
sell/report/customer_statements.py

Summary

Maintainability
A
1 hr
Test Coverage

Function find_source_order has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def find_source_order(self):
        # 查看原始单据，三种情况：收款单、销售退货单、销售发货单、核销单
        self.ensure_one()
        model_view = {
            'money.order': {'name': u'收款单',
Severity: Minor
Found in sell/report/customer_statements.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function find_source_order has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def find_source_order(self):
        # 查看原始单据，三种情况：收款单、销售退货单、销售发货单
        self.ensure_one()
        model_view = {
            'money.order': {'name': u'收款单',
Severity: Minor
Found in sell/report/customer_statements.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line too long (84 > 79 characters)
Open

            SELECT  ROW_NUMBER() OVER(ORDER BY partner_id, date, amount desc) AS id,
Severity: Minor
Found in sell/report/customer_statements.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (106 > 79 characters)
Open

            view = model == 'sell.delivery' and res.is_return and self.env.ref(view_dict['view_return']) \
Severity: Minor
Found in sell/report/customer_statements.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status