Sign upLogin

osbzr/gooderp_addons

View on GitHub
Star
sell/wizard/sell_receipt_wizard.py

Summary

Maintainability
A
1 hr
Test Coverage

Function button_ok has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def button_ok(self):
        self.ensure_one()
        res = []
        dict_part = {}
        if self.date_end < self.date_start:
Severity: Minor
Found in sell/wizard/sell_receipt_wizard.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _prepare_sell_receipt has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _prepare_sell_receipt(self, delivery):
        '''对于传入的发货单/退货单，为创建销售收款一览表准备数据'''
        self.ensure_one()
        factor = delivery.is_return and -1 or 1  # 如果是退货则金额均取反
        sell_amount = factor * (delivery.discount_amount + delivery.amount)
Severity: Minor
Found in sell/wizard/sell_receipt_wizard.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line too long (92 > 79 characters)
Open

                                                         (amount + partner_cost)) * 100 or 0
Severity: Minor
Found in sell/wizard/sell_receipt_wizard.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

.has_key() is deprecated, use 'in'
Open

            if not dict_part.has_key(delivery.partner_id):
Severity: Minor
Found in sell/wizard/sell_receipt_wizard.py by pep8

The {}.has_key() method is removed in Python 3: use the 'in' operator.

Okay: if "alph" in d:\n    print d["alph"]
W601: assert d.has_key('alph')

Line too long (84 > 79 characters)
Open

        for delivery in delivery_obj.search(self._get_domain(), order='partner_id'):
Severity: Minor
Found in sell/wizard/sell_receipt_wizard.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (98 > 79 characters)
Open

        warehouse = not delivery.is_return and delivery.warehouse_id or delivery.warehouse_dest_id
Severity: Minor
Found in sell/wizard/sell_receipt_wizard.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status