Sign upLogin

osbzr/gooderp_addons

View on GitHub
Star
staff_wages/models/staff_wages.py

Summary

Maintainability
C
1 day
Test Coverage

File staff_wages.py has 486 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
from odoo import fields, models, api
from odoo.exceptions import UserError

READONLY_STATES = {
Severity: Minor
Found in staff_wages/models/staff_wages.py - About 7 hrs to fix

    Function change_voucher has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def change_voucher(self):
        """
        生成并审核修正计提凭证
        :return:
        """
    Severity: Minor
    Found in staff_wages/models/staff_wages.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _personal_tax_value has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def _personal_tax_value(self):
        total = self.all_wage - self.endowment - \
            self.health - self.unemployment - self.housing_fund
        amount = total - 3500
        if amount > 80000:
    Severity: Minor
    Found in staff_wages/models/staff_wages.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create_credit_line has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def create_credit_line(self, voucher, name, account, credit, auxiliary_id):
    Severity: Minor
    Found in staff_wages/models/staff_wages.py - About 35 mins to fix

      Function _other_pay has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def _other_pay(self):
        '''选择结算账户，生成其他支出单 '''
        self.ensure_one()
        StaffWages = self.env.ref('staff_wages.staff_wages')
        endowment = self.env.ref('staff_wages.endowment')
      Severity: Minor
      Found in staff_wages/models/staff_wages.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function create_voucher has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def create_voucher(self, date):
        """
        生成并审核计提凭证
        :param date: 一个日期
        :return:
      Severity: Minor
      Found in staff_wages/models/staff_wages.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function staff_wages_accrued has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def staff_wages_accrued(self):
        """
        计提方法，如计提凭证已存在，判断当前期间是否与工资期间相同。
        如相同，反审核计提凭证并重新生成计提凭证；
        如不同，生成并审核修正凭证。
      Severity: Minor
      Found in staff_wages/models/staff_wages.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Line too long (90 > 79 characters)
      Open

          line_ids = fields.One2many('wages.line', 'order_id', u'工资明细行', states=READONLY_STATES,
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (92 > 79 characters)
      Open

                  vouch_obj, u'提本月公积金', housing_co.account_id, self.totoal_housing_fund_co, False)
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (81 > 79 characters)
      Open

                              and change_line.auxiliary_id == before_line.auxiliary_id:
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (88 > 79 characters)
      Open

                  if self.voucher_id.period_id == self.env['finance.period'].get_period(date):
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (99 > 79 characters)
      Open

          @api.depends('all_wage', 'endowment', 'health', 'unemployment', 'housing_fund', 'personal_tax')
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (85 > 79 characters)
      Open

              order = self.with_context(type='other_pay').env['other.money.order'].create({
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (80 > 79 characters)
      Open

                      'debit': val.get('debit') + line.all_wage + line.housing_fund_co
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (86 > 79 characters)
      Open

                  vouch_obj, u'提本月生育保险', maternity.account_id, self.totoal_maternity, False)
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (82 > 79 characters)
      Open

                  change_voucher, self.change_voucher_id = self.change_voucher_id, False
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (83 > 79 characters)
      Open

          @api.depends('all_wage', 'endowment', 'health', 'unemployment', 'housing_fund')
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (86 > 79 characters)
      Open

                  vouch_obj, u'提本月医疗保险', health_co.account_id, self.totoal_health_co, False)
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (98 > 79 characters)
      Open

                  vouch_obj, u'提本月失业保险', unemployment_co.account_id, self.totoal_unemployment_co, False)
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (98 > 79 characters)
      Open

          @api.depends('date_number', 'basic_date', 'add_wage', 'other_wage', 'basic_wage', 'deduction')
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (88 > 79 characters)
      Open

                      2 * (self.add_hour / 8) * (self.basic_wage / (self.basic_date or 1)), 2)
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (88 > 79 characters)
      Open

                      2 * (self.add_hour / 8) * (self.basic_wage / (self.basic_date or 1)), 2)
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (106 > 79 characters)
      Open

          other_money_order = fields.Many2one('other.money.order', u'对应付款单', readonly=True, ondelete='restrict',
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (102 > 79 characters)
      Open

              vouch_obj = self.env['voucher'].create({'date': date, 'ref': '%s,%s' % (self._name, self.id)})
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (86 > 79 characters)
      Open

                  change_voucher, record.change_voucher_id = record.change_voucher_id, False
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (84 > 79 characters)
      Open

              self.all_wage = self.wage + self.add_wage + self.other_wage - self.deduction
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (92 > 79 characters)
      Open

                  vouch_obj, u'提本月养老保险', endowment_co.account_id, self.totoal_endowment_co, False)
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (85 > 79 characters)
      Open

              order = self.with_context(type='other_pay').env['other.money.order'].create({
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (102 > 79 characters)
      Open

                      vouch_obj, u'提本月工资', credit_account.account_id, line.all_wage, line.name.auxiliary_id)
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (97 > 79 characters)
      Open

              other_money_order = self.with_context(type='other_pay').env['other.money.order'].create({
      Severity: Minor
      Found in staff_wages/models/staff_wages.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      There are no issues that match your filters.

      Category
      Status