Sign upLogin

osbzr/gooderp_addons

View on GitHub
Star
web_export_view_good/controllers/controllers.py

Summary

Maintainability
C
1 day
Test Coverage

Function from_data_excel has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    def from_data_excel(self, fields, rows_file_address):
        rows, file_address = rows_file_address
        if file_address:
            bk = xlrd.open_workbook(misc.file_open(
                file_address).name, formatting_info=True)
Severity: Minor
Found in web_export_view_good/controllers/controllers.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if isinstance(cell_value, basestring):
                            cell_value = re.sub("\r", " ", cell_value)
                        elif isinstance(cell_value, datetime.datetime):
                            cell_style = datetime_style
                        elif isinstance(cell_value, datetime.date):
Severity: Major
Found in web_export_view_good/controllers/controllers.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if len("%s" % (cell_value)) > columnwidth.get(cell_index):
                            columnwidth.update(
                                {cell_index: len("%s" % (cell_value))})
                    else:
    Severity: Major
    Found in web_export_view_good/controllers/controllers.py - About 45 mins to fix

      Function setOutCell has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def setOutCell(self, outSheet, col, row, value):
        """ Change cell value without changing formatting. """

        # 本方法来自 葡萄皮的数据空间[http://biotopiblog.sinaapp.com]
        # 链接http://biotopiblog.sinaapp.com/2014/06/python读写excel如何保留原有格式/
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_time has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_time(self, model):
        ISOTIMEFORMAT = "%Y-%m-%d"
        report_model = self.env['report.template'].search(
            [('model_id.model', '=', model)], limit=1)
        file_address = report_model and report_model[0].file_address or False
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing whitespace after ','
      Open

          blank_rows = fields.Integer(u'空白行数',required=True)
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Line too long (111 > 79 characters)
      Open

                                         fore-colour light_orange;border: left thin,right thin,top thin,bottom thin')
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (113 > 79 characters)
      Open

                                           fore-colour light_yellow;border: left thin,right thin,top thin,bottom thin')
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (105 > 79 characters)
      Open

              datetime_style = xlwt.easyxf('align: wrap yes; pattern: pattern solid, fore-colour light_yellow;\
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (131 > 79 characters)
      Open

                       http://stackoverflow.com/questions/6929115/python-xlwt-accessing-existing-cell-content-auto-adjust-column-width"""
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (81 > 79 characters)
      Open

                  'font: bold on,height 300;align: wrap on,vert centre, horiz center;')
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (82 > 79 characters)
      Open

                              if len("%s" % (cell_value)) > columnwidth.get(cell_index):
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (116 > 79 characters)
      Open

              return (str(time.strftime(ISOTIMEFORMAT, time.localtime(time.time()))), file_address,blank_rows,header_rows)
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (149 > 79 characters)
      Open

              date_style = xlwt.easyxf('align: wrap yes; pattern: pattern solid,fore-colour light_yellow;border: left thin,right thin,top thin,bottom thin\
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (104 > 79 characters)
      Open

                  style, colour_style, base_style, float_style, date_style, datetime_style = self.style_data()
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Missing whitespace after ','
      Open

              return (str(time.strftime(ISOTIMEFORMAT, time.localtime(time.time()))), file_address,blank_rows,header_rows)
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Line too long (100 > 79 characters)
      Open

              base_style = xlwt.easyxf('align: wrap yes,vert centre, horiz left; pattern: pattern solid, \
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (87 > 79 characters)
      Open

              return style, colour_style, base_style, float_style, date_style, datetime_style
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Missing whitespace after ','
      Open

          model_id = fields.Many2one('ir.model', u'模型',required=True)
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Line too long (102 > 79 characters)
      Open

              float_style = xlwt.easyxf('align: wrap yes,vert centre, horiz right ; pattern: pattern solid,\
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (122 > 79 characters)
      Open

                                               protection:formula_hidden yes;border: left thin,right thin,top thin,bottom thin',
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Missing whitespace after ','
      Open

          file_address = fields.Char(u'模板文件路径',required=True)
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Line too long (114 > 79 characters)
      Open

                                            fore-colour light_yellow;border: left thin,right thin,top thin,bottom thin')
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Missing whitespace after ','
      Open

              return (str(time.strftime(ISOTIMEFORMAT, time.localtime(time.time()))), file_address,blank_rows,header_rows)
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Line too long (83 > 79 characters)
      Open

              return u"attachment; filename=%s.xls" % filename.encode('ascii', 'replace')
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (103 > 79 characters)
      Open

              colour_style = xlwt.easyxf('align: wrap yes,vert centre, horiz center;pattern: pattern solid, \
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (90 > 79 characters)
      Open

                              elif isinstance(cell_value, float) or isinstance(cell_value, int):
      Severity: Minor
      Found in web_export_view_good/controllers/controllers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      There are no issues that match your filters.

      Category
      Status