Sign upLogin

ossplz/alsatian-fluent-assertions

View on GitHub
Star
src/matchers/elements-matcher.ts

Summary

Maintainability
C
1 day
Test Coverage

File elements-matcher.ts has 332 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { IPropertiesMatcher } from "./i-properties-matcher";
import { MatchMode, LocationMode, EqType, AssertionContext } from "../types";
import { IFluentCore } from "./i-fluent-core";
import { IElementsMatcher } from "./i-elements-matcher";
import { INarrowableFluentCore } from "./i-narrowable-fluent-core";
Severity: Minor
Found in src/matchers/elements-matcher.ts - About 4 hrs to fix

    Function _assertSequentialHasElements has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      protected _assertSequentialHasElements(
    expected: Array<any>,
    location: LocationMode,
    elMode: MatchMode,
    path: Array<string>
    Severity: Minor
    Found in src/matchers/elements-matcher.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _assertSequentialHasElements has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      protected _assertSequentialHasElements(
    expected: Array<any>,
    location: LocationMode,
    elMode: MatchMode,
    path: Array<string>
    Severity: Minor
    Found in src/matchers/elements-matcher.ts - About 1 hr to fix

      Function _heuristicMatch has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        protected _heuristicMatch(
    actual: any,
    expected: any,
    location: LocationMode,
    elMode: MatchMode.asserts | MatchMode.normal
      Severity: Minor
      Found in src/matchers/elements-matcher.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _assertContainsElements has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        protected _assertContainsElements(
    expected: Array<any>,
    location: LocationMode,
    elMode: MatchMode,
    path: Array<string>
      Severity: Minor
      Found in src/matchers/elements-matcher.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _assertHasElements has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        protected _assertHasElements(
    actual: Array<any>,
    expected: Array<any>,
    location: LocationMode,
    elMode: MatchMode,
      Severity: Minor
      Found in src/matchers/elements-matcher.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return this._deeplyEquals(actual, expected, EqType.strictly);
      Severity: Major
      Found in src/matchers/elements-matcher.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return expected(actual);
        Severity: Major
        Found in src/matchers/elements-matcher.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return false;
          Severity: Major
          Found in src/matchers/elements-matcher.ts - About 30 mins to fix

            Identical blocks of code found in 6 locations. Consider refactoring.
            Open

              constructor(actualValue: any,
    nextValue: any,
    initial: boolean,
    prevCore?: IFluentCore<any, any, any>,
    ctxt?: AssertionContext
            Severity: Major
            Found in src/matchers/elements-matcher.ts and 5 other locations - About 55 mins to fix
            src/matchers/operators.ts on lines 10..17
            src/matchers/properties-matcher-with-helpers.ts on lines 18..25
            src/matchers/properties-matcher.ts on lines 25..33
            src/matchers/simple-matcher-with-helpers.ts on lines 8..15
            src/matchers/simple-matcher.ts on lines 15..22

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (this.maybeInvert(!anyHas)) {
      this.specError(
        `should${this.negation}find sequence in array`,
        expected,
        this.actualValue
            Severity: Minor
            Found in src/matchers/elements-matcher.ts and 1 other location - About 35 mins to fix
            src/matchers/elements-matcher.ts on lines 56..62

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (this.maybeInvert(!result)) {
      this.specError(
        `some should${this.negation}satisfy predicate`,
        predicate,
        this.actualValue
            Severity: Minor
            Found in src/matchers/elements-matcher.ts and 1 other location - About 35 mins to fix
            src/matchers/elements-matcher.ts on lines 255..261

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status