Sign upLogin

otiai10/amesh-bot

View on GitHub
Star

Showing 18 of 18 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (c *SlackClient) DeleteMessage(ctx context.Context, msg interface{}) error {

    body := bytes.NewBuffer(nil)
    if err := json.NewEncoder(body).Encode(msg); err != nil {
        return err
Severity: Major
Found in service/slack.go and 1 other location - About 4 hrs to fix
service/slack.go on lines 180..217

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 320.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (c *SlackClient) UpdateMessage(ctx context.Context, msg interface{}) error {

    body := bytes.NewBuffer(nil)
    if err := json.NewEncoder(body).Encode(msg); err != nil {
        return err
Severity: Major
Found in service/slack.go and 1 other location - About 4 hrs to fix
service/slack.go on lines 141..178

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 320.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method ForecastCommand.FormatForecastToSlackBlocks has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
Open

func (cmd ForecastCommand) FormatForecastToSlackBlocks(entries []api.ComprehensiveForecastEntry, overview *api.OverviewForecast) (blocks []slack.Block) {

    k := 0 // まずは一番うえのAreaだけ見る, which means 伊豆諸島・小笠原諸島を無視している

    // {{{ エリア「k」における情報をまず抽出
Severity: Minor
Found in commands/forecast.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageCommand.Execute has 89 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (cmd ImageCommand) Execute(ctx context.Context, client service.ISlackClient, event slackevents.AppMentionEvent) (err error) {

    help := bytes.NewBuffer(nil)
    unsafe := false
    verbose := false
Severity: Major
Found in commands/image.go - About 2 hrs to fix

    Method ForecastCommand.FormatForecastToSlackBlocks has 74 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (cmd ForecastCommand) FormatForecastToSlackBlocks(entries []api.ComprehensiveForecastEntry, overview *api.OverviewForecast) (blocks []slack.Block) {

    k := 0 // まずは一番うえのAreaだけ見る, which means 伊豆諸島・小笠原諸島を無視している

    // {{{ エリア「k」における情報をまず抽出
    Severity: Minor
    Found in commands/forecast.go - About 1 hr to fix

      Method Controller.Image has 59 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (c *Controller) Image(w http.ResponseWriter, req *http.Request) {

    origin := req.URL.Query().Get("url")
    filter := req.URL.Query().Get("filter")
    levelstr := req.URL.Query().Get("level")
      Severity: Minor
      Found in controllers/image.go - About 1 hr to fix

        Method SlackClient.PostMessage has 7 return statements (exceeds 4 allowed).
        Open

        func (c *SlackClient) PostMessage(ctx context.Context, msg interface{}) (*PostMessageResponse, error) {
    body := bytes.NewBuffer(nil)
    if err := json.NewEncoder(body).Encode(msg); err != nil {
        return nil, err
    }
        Severity: Major
        Found in service/slack.go - About 45 mins to fix

          Method ImageCommand.Execute has 7 return statements (exceeds 4 allowed).
          Open

          func (cmd ImageCommand) Execute(ctx context.Context, client service.ISlackClient, event slackevents.AppMentionEvent) (err error) {

    help := bytes.NewBuffer(nil)
    unsafe := false
    verbose := false
          Severity: Major
          Found in commands/image.go - About 45 mins to fix

            Method SlackClient.DeleteMessage has 7 return statements (exceeds 4 allowed).
            Open

            func (c *SlackClient) DeleteMessage(ctx context.Context, msg interface{}) error {

    body := bytes.NewBuffer(nil)
    if err := json.NewEncoder(body).Encode(msg); err != nil {
        return err
            Severity: Major
            Found in service/slack.go - About 45 mins to fix

              Method ForecastCommand.Execute has 7 return statements (exceeds 4 allowed).
              Open

              func (cmd ForecastCommand) Execute(ctx context.Context, client service.ISlackClient, event slackevents.AppMentionEvent) error {
    city := "tokyo"
    list := false
    help := bytes.NewBuffer(nil)
    fset := largo.NewFlagSet("forecast", largo.ContinueOnError)
              Severity: Major
              Found in commands/forecast.go - About 45 mins to fix

                Method SlackClient.UpdateMessage has 7 return statements (exceeds 4 allowed).
                Open

                func (c *SlackClient) UpdateMessage(ctx context.Context, msg interface{}) error {

    body := bytes.NewBuffer(nil)
    if err := json.NewEncoder(body).Encode(msg); err != nil {
        return err
                Severity: Major
                Found in service/slack.go - About 45 mins to fix

                  Method SlackClient.GetThreadHistory has 6 return statements (exceeds 4 allowed).
                  Open

                  func (c *SlackClient) GetThreadHistory(ctx context.Context, channel, thread string) ([]slack.Msg, error) {
    // api := slack.New(c.AccessToken)
    // api.GetConversationRepliesContext(ctx, &slack.GetConversationRepliesParameters{})
    query := url.Values{"channel": []string{channel}, "ts": []string{thread}}
    req, err := http.NewRequest("GET", "https://slack.com/api/conversations.replies?"+query.Encode(), nil)
                  Severity: Major
                  Found in service/slack.go - About 40 mins to fix

                    Method SlackClient.GetChannelInfo has 6 return statements (exceeds 4 allowed).
                    Open

                    func (c *SlackClient) GetChannelInfo(ctx context.Context, id string) (info slack.Channel, err error) {
    req, err := http.NewRequest("GET", "https://slack.com/api/conversations.info?channel="+id, nil)
    if err != nil {
        // return err
        return
                    Severity: Major
                    Found in service/slack.go - About 40 mins to fix

                      Method AmeshCommand.animated has 5 return statements (exceeds 4 allowed).
                      Open

                      func (cmd AmeshCommand) animated(
    ctx context.Context,
    client service.ISlackClient,
    event slackevents.AppMentionEvent,
    now time.Time,
                      Severity: Major
                      Found in commands/amesh.go - About 35 mins to fix

                        Method Controller.OAuth has 5 return statements (exceeds 4 allowed).
                        Open

                        func (c *Controller) OAuth(w http.ResponseWriter, req *http.Request) {
    code := req.URL.Query().Get("code")
    if code == "" {
        w.WriteHeader(http.StatusBadRequest)
        return
                        Severity: Major
                        Found in controllers/oauth.go - About 35 mins to fix

                          Method LGTM.Random has 5 return statements (exceeds 4 allowed).
                          Open

                          func (lgtm LGTM) Random() (string, string, error) {
    client := &http.Client{
        CheckRedirect: func(req *http.Request, via []*http.Request) error {
            return http.ErrUseLastResponse
        },
                          Severity: Major
                          Found in service/lgtm.go - About 35 mins to fix

                            Method AICompletion.Execute has 5 return statements (exceeds 4 allowed).
                            Open

                            func (cmd AICompletion) Execute(ctx context.Context, client service.ISlackClient, event slackevents.AppMentionEvent) (err error) {

    forceThreadReply, err := cmd.shouldForceThreadReply(ctx, client, event.Channel)
    if err != nil {
        return err
                            Severity: Major
                            Found in commands/openaicompletion.go - About 35 mins to fix

                              Method Bot.handle has 5 return statements (exceeds 4 allowed).
                              Open

                              func (b *Bot) handle(ctx context.Context, client service.ISlackClient, event slackevents.AppMentionEvent) *CommandError {
    if tokens := largo.Tokenize(event.Text)[1:]; len(tokens) != 0 && tokens[0] == "help" {
        return errwrap(b.Help(ctx, client, event), "builtin:help", event)
    }
    for _, cmd := range b.Commands {
                              Severity: Major
                              Found in bot/bot.go - About 35 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language