Sign upLogin

otwcode/otwarchive

View on GitHub
Star
app/controllers/tag_set_nominations_controller.rb

Summary

Maintainability
F
3 days
Test Coverage

Method collect_update_multiple_results has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

  def collect_update_multiple_results
    TagSet::TAG_TYPES_INITIALIZABLE.each do |tag_type|
      @approve[tag_type] = []
      @synonym[tag_type] = []
      @reject[tag_type] = []
Severity: Minor
Found in app/controllers/tag_set_nominations_controller.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setup_for_review has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

  def setup_for_review
    set_limit
    @nom_limit = 30
    @nominations = HashWithIndifferentAccess.new
    @nominations_count = HashWithIndifferentAccess.new
Severity: Minor
Found in app/controllers/tag_set_nominations_controller.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_multiple has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

  def update_multiple
    unless @tag_set.user_is_moderator?(current_user)
      flash[:error] = ts("You don't have permission to do that.")
      redirect_to tag_set_path(@tag_set) and return
    end
Severity: Minor
Found in app/controllers/tag_set_nominations_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File tag_set_nominations_controller.rb has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class TagSetNominationsController < ApplicationController
  cache_sweeper :tag_set_sweeper

  before_action :users_only
  before_action :load_tag_set, except: [ :index ]
Severity: Minor
Found in app/controllers/tag_set_nominations_controller.rb - About 3 hrs to fix

    Class TagSetNominationsController has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class TagSetNominationsController < ApplicationController
  cache_sweeper :tag_set_sweeper

  before_action :users_only
  before_action :load_tag_set, except: [ :index ]
    Severity: Minor
    Found in app/controllers/tag_set_nominations_controller.rb - About 2 hrs to fix

      Method update_multiple has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def update_multiple
    unless @tag_set.user_is_moderator?(current_user)
      flash[:error] = ts("You don't have permission to do that.")
      redirect_to tag_set_path(@tag_set) and return
    end
      Severity: Major
      Found in app/controllers/tag_set_nominations_controller.rb - About 2 hrs to fix

        Method collect_update_multiple_results has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def collect_update_multiple_results
    TagSet::TAG_TYPES_INITIALIZABLE.each do |tag_type|
      @approve[tag_type] = []
      @synonym[tag_type] = []
      @reject[tag_type] = []
        Severity: Minor
        Found in app/controllers/tag_set_nominations_controller.rb - About 1 hr to fix

          Method setup_for_review has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def setup_for_review
    set_limit
    @nom_limit = 30
    @nominations = HashWithIndifferentAccess.new
    @nominations_count = HashWithIndifferentAccess.new
          Severity: Minor
          Found in app/controllers/tag_set_nominations_controller.rb - About 1 hr to fix

            Method index has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def index
    if params[:user_id]
      @user = User.find_by(login: params[:user_id])
      if @user != current_user
        flash[:error] = ts("You can only view your own nominations, sorry.")
            Severity: Minor
            Found in app/controllers/tag_set_nominations_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    render_index_on_error and return
            Severity: Major
            Found in app/controllers/tag_set_nominations_controller.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    redirect_to tag_set_nominations_path(@tag_set) and return
              Severity: Major
              Found in app/controllers/tag_set_nominations_controller.rb - About 30 mins to fix

                Method check_pseud_ownership has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def check_pseud_ownership
    if !tag_set_nomination_params[:pseud_id].blank?
      pseud = Pseud.find(tag_set_nomination_params[:pseud_id])
      unless pseud && current_user && current_user.pseuds.include?(pseud)
        flash[:error] = ts("You can't nominate tags with that pseud.")
                Severity: Minor
                Found in app/controllers/tag_set_nominations_controller.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method load_nomination has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def load_nomination
    @tag_set_nomination = @tag_set.tag_set_nominations.find_by(id: params[:id])
    unless @tag_set_nomination
      flash[:error] = ts("Which nominations did you want to work with?")
      redirect_to tag_set_path(@tag_set) and return
                Severity: Minor
                Found in app/controllers/tag_set_nominations_controller.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      pseud = Pseud.find(tag_set_nomination_params[:pseud_id])
      unless pseud && current_user && current_user.pseuds.include?(pseud)
        flash[:error] = ts("You can't nominate tags with that pseud.")
        redirect_to root_path and return
      end
                Severity: Minor
                Found in app/controllers/tag_set_nominations_controller.rb and 1 other location - About 15 mins to fix
                app/controllers/bookmarks_controller.rb on lines 17..21

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status