Sign upLogin

otwcode/otwarchive

View on GitHub
Star
app/models/collection.rb

Summary

Maintainability
D
2 days
Test Coverage

Class Collection has 52 methods (exceeds 20 allowed). Consider refactoring.
Open

class Collection < ApplicationRecord
  include Filterable
  include WorksOwner

  has_attached_file :icon,
Severity: Major
Found in app/models/collection.rb - About 7 hrs to fix

    Method sorted_and_filtered has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.sorted_and_filtered(sort, filters, page)
    pagination_args = {page: page}

    # build up the query with scopes based on the options the user specifies
    query = Collection.top_level
    Severity: Minor
    Found in app/models/collection.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File collection.rb has 331 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Collection < ApplicationRecord
  include Filterable
  include WorksOwner

  has_attached_file :icon,
    Severity: Minor
    Found in app/models/collection.rb - About 3 hrs to fix

      Method orphan has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.orphan(pseuds, collections, default=true)
    for pseud in pseuds
      for collection in collections
        if pseud && collection && collection.owners.include?(pseud)
          orphan_pseud = default ? User.orphan_account.default_pseud : User.orphan_account.pseuds.find_or_create_by(name: pseud.name)
      Severity: Minor
      Found in app/models/collection.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method sorted_and_filtered has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.sorted_and_filtered(sort, filters, page)
    pagination_args = {page: page}

    # build up the query with scopes based on the options the user specifies
    query = Collection.top_level
      Severity: Minor
      Found in app/models/collection.rb - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

            if (self.parent && self.parent.parent) || (self.parent && !self.children.empty?) || (!self.children.empty? && !self.children.collect(&:children).flatten.empty?)
      errors.add(:base, ts("Sorry, but %{name} is a subcollection, so it can't also be a parent collection.", name: parent.name))
    end
        Severity: Major
        Found in app/models/collection.rb - About 40 mins to fix

          Method collection_depth has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def collection_depth
    if (self.parent && self.parent.parent) || (self.parent && !self.children.empty?) || (!self.children.empty? && !self.children.collect(&:children).flatten.empty?)
      errors.add(:base, ts("Sorry, but %{name} is a subcollection, so it can't also be a parent collection.", name: parent.name))
    end
  end
          Severity: Minor
          Found in app/models/collection.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            has_attached_file :icon,
  styles: { standard: "100x100>" },
  url: "/system/:class/:attachment/:id/:style/:basename.:extension",
  path: %w(staging production).include?(Rails.env) ? ":class/:attachment/:id/:style.:extension" : ":rails_root/public:url",
  storage: %w(staging production).include?(Rails.env) ? :s3 : :filesystem,
          Severity: Minor
          Found in app/models/collection.rb and 1 other location - About 30 mins to fix
          app/models/skin.rb on lines 51..59

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status