Showing 136 of 136 total issues
Method create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def create
if @auth = Authorization.find_from_hash(auth_data)
@auth.update_attributes(
token: auth_data['credentials']['token'],
secret: auth_data['credentials']['secret']- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def create
begin
params[:ip] = request.remote_ip
params[:organization_id] = @campaign.organization_id
params[:password] = SecureRandom.hex- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this function. Open
Open
return _48>0;Avoid too many return statements within this function. Open
Open
return false;Avoid too many return statements within this function. Open
Open
return false;Avoid too many return statements within this function. Open
Open
return false;Avoid too many return statements within this function. Open
Open
return ((min&&_46>=_44)||(max&&_46<_44)||(!min&&!max&&_46===_44));Avoid too many return statements within this function. Open
Open
return _47>0;Avoid too many return statements within this function. Open
Open
return ((min&&_49>=_44)||(max&&_49<_44)||(!min&&!max&&_49===_44));Avoid too many return statements within this function. Open
Open
if (className != toString.call(b)) return false;Avoid too many return statements within this function. Open
Open
if ('constructor' in a != 'constructor' in b || a.constructor != b.constructor) return false;Avoid too many return statements within this function. Open
Open
return _47>0;Avoid too many return statements within this function. Open
Open
return _.values(obj);Avoid too many return statements within this function. Open
Open
return ((min&&_47>=_44)||(max&&_47<_44)||(!min&&!max&&_47===_44));Avoid too many return statements within this function. Open
Open
return false;Avoid too many return statements within this function. Open
Open
return -1;Avoid too many return statements within this function. Open
Open
return result;Avoid too many return statements within this function. Open
Open
return false;Avoid too many return statements within this function. Open
Open
return false;Avoid too many return statements within this function. Open
Open
if (typeof a != 'object' || typeof b != 'object') return false;