Sign upLogin

outcastgeek/jrzmq

View on GitHub
Star

Showing 10 of 16 total issues

Method recv has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def recv reply
    if reply and @reply_to
      reply = reply.is_a?(Array) ? [@reply_to, ''].concat(reply) : [@reply_to, '', reply]
      send_to_broker MDP::W_REPLY, nil, reply
    end
Severity: Minor
Found in zguide/mdwrkapi.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method recv has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def recv reply
    if reply and @reply_to
      reply = reply.is_a?(Array) ? [@reply_to, ''].concat(reply) : [@reply_to, '', reply]
      send_to_broker MDP::W_REPLY, nil, reply
    end
Severity: Minor
Found in zguide/mdwrkapi.rb - About 1 hr to fix

    Method mediate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def mediate
    #count = 0
    loop do
      #puts "mediate: count: #{count}"
      #count += 1
    Severity: Minor
    Found in zguide/mdbroker.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method mediate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def mediate
    #count = 0
    loop do
      #puts "mediate: count: #{count}"
      #count += 1
    Severity: Minor
    Found in zguide/mdbroker.rb - About 1 hr to fix

      Method process_worker has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def process_worker address, message
    command = message.pop_string #message.shift

    worker_exists = @workers[address]
    worker = require_worker address
      Severity: Minor
      Found in zguide/mdbroker.rb - About 1 hr to fix

        Method process_worker has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def process_worker address, message
    command = message.pop_string #message.shift

    worker_exists = @workers[address]
    worker = require_worker address
        Severity: Minor
        Found in zguide/mdbroker.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method s_dump has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def s_dump(sock)
  puts "------------------------------------"
  # Build an array to hold all the parts
  messages = []
  zmsg = sock.recv
        Severity: Minor
        Found in guide/zhelpers.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method s_dump has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def s_dump(sock)
  puts "------------------------------------"
  # Build an array to hold all the parts
  messages = []
  zmsg = sock.recv
        Severity: Minor
        Found in zguide/zhelpers.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method service_success has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def service_success client, uuid
  # Attempt to process a single request, return True if successful
  return true unless File.exist?(request_filename(uuid))

  request = JSON.parse(File.read(request_filename(uuid)))
        Severity: Minor
        Found in zguide/titanic.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method send has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def send(message)
    @retries.times do |tries|
      raise("Send: #{message} failed") unless @socket.send(message)
      if ZMQ.poll([ZMQ::PollItem.new(@socket, ZMQ::POLLIN)], @timeout)
        yield @socket.recv
        Severity: Minor
        Found in guide/lpclient.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language