Sign upLogin

owncloud/core

View on GitHub
Star
apps/comments/lib/Dav/CommentsPlugin.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method onReport has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function onReport($reportName, $report, $uri) {
        $node = $this->server->tree->getNodeForPath($uri);
        if (!$node instanceof EntityCollection || $reportName !== self::REPORT_NAME) {
            throw new ReportNotSupported();
        }
Severity: Minor
Found in apps/comments/lib/Dav/CommentsPlugin.php - About 1 hr to fix

    Method createComment has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function createComment($objectType, $objectId, $data, $contentType = 'application/json') {
        if (\explode(';', $contentType)[0] === 'application/json') {
            $data = \json_decode($data, true);
        } else {
            throw new UnsupportedMediaType();
    Severity: Minor
    Found in apps/comments/lib/Dav/CommentsPlugin.php - About 1 hr to fix

      Function onReport has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function onReport($reportName, $report, $uri) {
        $node = $this->server->tree->getNodeForPath($uri);
        if (!$node instanceof EntityCollection || $reportName !== self::REPORT_NAME) {
            throw new ReportNotSupported();
        }
      Severity: Minor
      Found in apps/comments/lib/Dav/CommentsPlugin.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createComment has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function createComment($objectType, $objectId, $data, $contentType = 'application/json') {
        if (\explode(';', $contentType)[0] === 'application/json') {
            $data = \json_decode($data, true);
        } else {
            throw new UnsupportedMediaType();
      Severity: Minor
      Found in apps/comments/lib/Dav/CommentsPlugin.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status