File CardDavBackend.php has 591 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/**
 * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
 * @author Björn Schießle <bjoern@schiessle.org>
 * @author Georg Ehrke <georg@owncloud.com>

CardDavBackend has 30 functions (exceeds 20 allowed). Consider refactoring.

Open

class CardDavBackend implements BackendInterface, SyncSupport {
    /** @var Principal */
    private $principalBackend;

    /** @var string */

Method getChangesForAddressBook has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getChangesForAddressBook($addressBookId, $syncToken, $syncLevel, $limit = null) {
        // Current synctoken
        $stmt = $this->db->prepare('SELECT `synctoken` FROM `*PREFIX*addressbooks` WHERE `id` = ?');
        $stmt->execute([ $addressBookId ]);
        $currentToken = $stmt->fetchColumn();

Method searchEx has 39 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function searchEx($addressBookId, $pattern, $searchProperties, $options, $limit = 100, $offset = 0) {
        $query = $this->db->getQueryBuilder();
        $cardIdSelect = $this->db->getQueryBuilder();
        $cardIdSelect->selectDistinct('cp.cardid')->from($this->dbCardsPropertiesTable, 'cp');

Method getAddressBooksForUser has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getAddressBooksForUser($principalUri) {
        $addressBooks = $this->getUsersOwnAddressBooks($principalUri);

        // query for shared calendars
        $principals = $this->principalBackend->getGroupMembership($principalUri, true);

Method createAddressBook has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function createAddressBook($principalUri, $url, array $properties) {
        $values = [
            'displayname' => null,
            'description' => null,
            'principaluri' => $principalUri,

Function getChangesForAddressBook has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

    public function getChangesForAddressBook($addressBookId, $syncToken, $syncLevel, $limit = null) {
        // Current synctoken
        $stmt = $this->db->prepare('SELECT `synctoken` FROM `*PREFIX*addressbooks` WHERE `id` = ?');
        $stmt->execute([ $addressBookId ]);
        $currentToken = $stmt->fetchColumn();

• Read up
  Read up

Function updateProperties has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

    protected function updateProperties($addressBookId, $cardUri, $vCardSerialized) {
        $cardId = $this->getCardId($addressBookId, $cardUri);
        $vCard = $this->readCard($vCardSerialized);

        $this->purgeProperties($addressBookId, $cardId);

• Read up
  Read up

Method updateProperties has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function updateProperties($addressBookId, $cardUri, $vCardSerialized) {
        $cardId = $this->getCardId($addressBookId, $cardUri);
        $vCard = $this->readCard($vCardSerialized);

        $this->purgeProperties($addressBookId, $cardId);

Method updateAddressBook has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function updateAddressBook($addressBookId, \Sabre\DAV\PropPatch $propPatch) {
        $supportedProperties = [
            '{DAV:}displayname',
            '{' . Plugin::NS_CARDDAV . '}addressbook-description',
        ];

Method deleteCard has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function deleteCard($addressBookId, $cardUri) {
        try {
            $cardId = $this->getCardId($addressBookId, $cardUri);
        } catch (\InvalidArgumentException $e) {
            $cardId = null;

Method searchEx has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function searchEx($addressBookId, $pattern, $searchProperties, $options, $limit = 100, $offset = 0) {

Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function search($addressBookId, $pattern, $searchProperties, $limit = 100, $offset = 0) {

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

        IDBConnection $db,
        Principal $principalBackend,
        GroupPrincipalBackend $groupPrincipalBackend,
        EventDispatcherInterface $dispatcher = null,
        $legacyMode = false

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ($syncToken) {
            $query = 'SELECT `uri`, `operation` FROM `*PREFIX*addressbookchanges` WHERE `synctoken` >= ? AND `synctoken` < ? AND `addressbookid` = ? ORDER BY `synctoken`';

            // Fetching all changes
            $stmt = $this->db->prepare($query, $limit ?: null, $limit ? 0 : null);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    private function convertPrincipal($principalUri, $toV2 = null) {
        if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
            list(, $name) = \Sabre\Uri\split($principalUri);
            $toV2 = $toV2 === null ? !$this->legacyMode : $toV2;
            if ($toV2) {

• Read up
  Read up