owncloud/core

View on GitHub
apps/dav/lib/Connector/Sabre/ObjectTree.php

Summary

Maintainability
C
1 day
Test Coverage

Function getNodeForPath has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function getNodeForPath($path) {
        if (!$this->fileView) {
            throw new \Sabre\DAV\Exception\ServiceUnavailable('filesystem not setup');
        }

Severity: Minor
Found in apps/dav/lib/Connector/Sabre/ObjectTree.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getNodeForPath has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getNodeForPath($path) {
        if (!$this->fileView) {
            throw new \Sabre\DAV\Exception\ServiceUnavailable('filesystem not setup');
        }

Severity: Major
Found in apps/dav/lib/Connector/Sabre/ObjectTree.php - About 2 hrs to fix

    Method copy has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function copy($source, $destination) {
            if (!$this->fileView) {
                throw new \Sabre\DAV\Exception\ServiceUnavailable('filesystem not setup');
            }
    
    
    Severity: Minor
    Found in apps/dav/lib/Connector/Sabre/ObjectTree.php - About 1 hr to fix

      Function copy has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function copy($source, $destination) {
              if (!$this->fileView) {
                  throw new \Sabre\DAV\Exception\ServiceUnavailable('filesystem not setup');
              }
      
      
      Severity: Minor
      Found in apps/dav/lib/Connector/Sabre/ObjectTree.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function resolveChunkFile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function resolveChunkFile($path) {
              if (\OC_FileChunking::isWebdavChunk()) {
                  // resolve to real file name to find the proper node
                  list($dir, $name) = \Sabre\Uri\split($path);
                  if ($dir == '/' || $dir == '.') {
      Severity: Minor
      Found in apps/dav/lib/Connector/Sabre/ObjectTree.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status