Sign upLogin

owncloud/core

View on GitHub
Star
apps/dav/lib/Files/PublicFiles/SharedNodeTrait.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method getACL has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getACL() {
        $acl = [
            [
                'privilege' => '{DAV:}all',
                'principal' => '{DAV:}owner',
Severity: Minor
Found in apps/dav/lib/Files/PublicFiles/SharedNodeTrait.php - About 1 hr to fix

    Function getDavPermissions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getDavPermissions() {
        $node = $this->getNode();
        $p = '';
        if ($node->isDeletable() && $this->checkSharePermissions(Constants::PERMISSION_DELETE)) {
            $p .= 'D';
    Severity: Minor
    Found in apps/dav/lib/Files/PublicFiles/SharedNodeTrait.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getACL has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getACL() {
        $acl = [
            [
                'privilege' => '{DAV:}all',
                'principal' => '{DAV:}owner',
    Severity: Minor
    Found in apps/dav/lib/Files/PublicFiles/SharedNodeTrait.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status