Sign upLogin

owncloud/core

View on GitHub
Star
apps/federatedfilesharing/lib/Controller/OcmController.php

Summary

Maintainability
D
2 days
Test Coverage

Method processNotification has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function processNotification(
        $notificationType,
        $resourceType,
        $providerId,
        $notification
Severity: Major
Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 5 hrs to fix

    File OcmController.php has 330 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * @author Viktar Dubiniuk <dubiniuk@owncloud.com>
 *
 * @copyright Copyright (c) 2018, ownCloud GmbH
    Severity: Minor
    Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 3 hrs to fix

      Method createShare has 95 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createShare(
        $shareWith,
        $name,
        $description,
        $providerId,
      Severity: Major
      Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 3 hrs to fix

        Function processNotification has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function processNotification(
        $notificationType,
        $resourceType,
        $providerId,
        $notification
        Severity: Minor
        Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method createShare has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $shareWith,
        $name,
        $description,
        $providerId,
        $owner,
        Severity: Major
        Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 1 hr to fix

          Function createShare has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function createShare(
        $shareWith,
        $name,
        $description,
        $providerId,
          Severity: Minor
          Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $appName,
        IRequest $request,
        OcmMiddleware $ocmMiddleware,
        IURLGenerator $urlGenerator,
        IUserManager $userManager,
          Severity: Major
          Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                        return new JSONResponse(
                ['message' => $e->getMessage()],
                $e->getHttpStatusCode()
            );
            Severity: Major
            Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return new JSONResponse(
            [],
            Http::STATUS_CREATED
        );
              Severity: Major
              Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return new JSONResponse(
                [
                    'message' => "internal server error, was not able to process notification"
                ],
                Http::STATUS_INTERNAL_SERVER_ERROR
                Severity: Major
                Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 30 mins to fix

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function __construct(
        $appName,
        IRequest $request,
        OcmMiddleware $ocmMiddleware,
        IURLGenerator $urlGenerator,
                  Severity: Major
                  Found in apps/federatedfilesharing/lib/Controller/OcmController.php and 4 other locations - About 2 hrs to fix
                  apps/files_sharing/lib/Controller/NotificationController.php on lines 54..73
                  apps/updatenotification/lib/Controller/AdminController.php on lines 67..86
                  core/Controller/AvatarController.php on lines 85..105
                  core/Controller/LoginController.php on lines 76..95

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 140.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status