Sign upLogin

owncloud/core

View on GitHub
Star
apps/federatedfilesharing/lib/Controller/RequestHandlerController.php

Summary

Maintainability
C
1 day
Test Coverage

Method createShare has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createShare() {
        try {
            $this->ocmMiddleware->assertIncomingSharingEnabled();
            $remote = $this->request->getParam('remote', null);
            $token = $this->request->getParam('token', null);
Severity: Major
Found in apps/federatedfilesharing/lib/Controller/RequestHandlerController.php - About 3 hrs to fix

    File RequestHandlerController.php has 278 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
 * @author Björn Schießle <bjoern@schiessle.org>
 * @author Joas Schilling <coding@schilljs.com>
    Severity: Minor
    Found in apps/federatedfilesharing/lib/Controller/RequestHandlerController.php - About 2 hrs to fix

      Method reShare has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function reShare($id) {
        $token = $this->request->getParam('token', null);
        $shareWith = $this->request->getParam('shareWith', null);
        $permission = $this->request->getParam('permission', null);
        $remoteId = $this->request->getParam('remoteId', null);
      Severity: Minor
      Found in apps/federatedfilesharing/lib/Controller/RequestHandlerController.php - About 1 hr to fix

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $appName,
        IRequest $request,
        OcmMiddleware $ocmMiddleware,
        IUserManager $userManager,
        AddressHandler $addressHandler,
        Severity: Minor
        Found in apps/federatedfilesharing/lib/Controller/RequestHandlerController.php - About 45 mins to fix

          Function createShare has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function createShare() {
        try {
            $this->ocmMiddleware->assertIncomingSharingEnabled();
            $remote = $this->request->getParam('remote', null);
            $token = $this->request->getParam('token', null);
          Severity: Minor
          Found in apps/federatedfilesharing/lib/Controller/RequestHandlerController.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  try {
            $token = $this->request->getParam('token', null);
            $this->ocmMiddleware->assertOutgoingSharingEnabled();
            $share = $this->ocmMiddleware->getValidShare($id, $token);
            $this->fedShareManager->declineShare($share);
          Severity: Minor
          Found in apps/federatedfilesharing/lib/Controller/RequestHandlerController.php and 1 other location - About 40 mins to fix
          apps/federatedfilesharing/lib/Controller/RequestHandlerController.php on lines 264..287

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  try {
            $this->ocmMiddleware->assertOutgoingSharingEnabled();
            $token = $this->request->getParam('token', null);
            $share = $this->ocmMiddleware->getValidShare($id, $token);
            $this->fedShareManager->acceptShare($share);
          Severity: Minor
          Found in apps/federatedfilesharing/lib/Controller/RequestHandlerController.php and 1 other location - About 40 mins to fix
          apps/federatedfilesharing/lib/Controller/RequestHandlerController.php on lines 302..325

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              public function __construct(
        $appName,
        IRequest $request,
        OcmMiddleware $ocmMiddleware,
        IUserManager $userManager,
          Severity: Major
          Found in apps/federatedfilesharing/lib/Controller/RequestHandlerController.php and 4 other locations - About 35 mins to fix
          core/Controller/TokenController.php on lines 56..62
          core/Controller/TwoFactorChallengeController.php on lines 61..74
          settings/Controller/CertificateController.php on lines 56..69
          settings/Controller/SettingsPageController.php on lines 55..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 92.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status