Sign upLogin

owncloud/core

View on GitHub
Star
apps/federatedfilesharing/lib/DiscoveryManager.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function discover has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private function discover($remote) {
        // Check if something is in the cache
        if ($cacheData = $this->cache->get($remote)) {
            return \json_decode($cacheData, true);
        }
Severity: Minor
Found in apps/federatedfilesharing/lib/DiscoveryManager.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ocmDiscover has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private function ocmDiscover($remote) {
        // Check if something is in the cache
        if ($cacheData = $this->cache->get('OCM' . $remote)) {
            return \json_decode($cacheData, true);
        }
Severity: Minor
Found in apps/federatedfilesharing/lib/DiscoveryManager.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ocmDiscover has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function ocmDiscover($remote) {
        // Check if something is in the cache
        if ($cacheData = $this->cache->get('OCM' . $remote)) {
            return \json_decode($cacheData, true);
        }
Severity: Minor
Found in apps/federatedfilesharing/lib/DiscoveryManager.php - About 1 hr to fix

    Method discover has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function discover($remote) {
        // Check if something is in the cache
        if ($cacheData = $this->cache->get($remote)) {
            return \json_decode($cacheData, true);
        }
    Severity: Minor
    Found in apps/federatedfilesharing/lib/DiscoveryManager.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status