Sign upLogin

owncloud/core

View on GitHub
Star
apps/federatedfilesharing/lib/FedShareManager.php

Summary

Maintainability
C
1 day
Test Coverage

Method createShare has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createShare(
        Address $ownerAddress,
        Address $sharedByAddress,
        $shareWith,
        $remoteId,
Severity: Major
Found in apps/federatedfilesharing/lib/FedShareManager.php - About 2 hrs to fix

    File FedShareManager.php has 254 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * @author Viktar Dubiniuk <dubiniuk@owncloud.com>
 *
 * @copyright Copyright (c) 2018, ownCloud GmbH
    Severity: Minor
    Found in apps/federatedfilesharing/lib/FedShareManager.php - About 2 hrs to fix

      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              FederatedShareProvider $federatedShareProvider,
        Notifications $notifications,
        IUserManager $userManager,
        ActivityManager $activityManager,
        NotificationManager $notificationManager,
      Severity: Major
      Found in apps/federatedfilesharing/lib/FedShareManager.php - About 50 mins to fix

        Method publishActivity has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $affectedUser,
        $subject,
        $subjectParams,
        $objectType,
        $objectId,
        Severity: Major
        Found in apps/federatedfilesharing/lib/FedShareManager.php - About 50 mins to fix

          Method createShare has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  Address $ownerAddress,
        Address $sharedByAddress,
        $shareWith,
        $remoteId,
        $name,
          Severity: Minor
          Found in apps/federatedfilesharing/lib/FedShareManager.php - About 45 mins to fix

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function __construct(
        FederatedShareProvider $federatedShareProvider,
        Notifications $notifications,
        IUserManager $userManager,
        ActivityManager $activityManager,
            Severity: Major
            Found in apps/federatedfilesharing/lib/FedShareManager.php and 4 other locations - About 1 hr to fix
            apps/federation/lib/TrustedServers.php on lines 77..93
            apps/systemtags/lib/Activity/Listener.php on lines 67..83
            lib/private/Repair/MoveAvatarIntoSubFolder.php on lines 76..92
            lib/private/Repair/MoveAvatarOutsideHome.php on lines 77..93

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 116.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status