Sign upLogin

owncloud/core

View on GitHub
Star
apps/federatedfilesharing/lib/Notifications.php

Summary

Maintainability
D
2 days
Test Coverage

File Notifications.php has 263 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @author Björn Schießle <bjoern@schiessle.org>
 * @author Joas Schilling <coding@schilljs.com>
 * @author Lukas Reschke <lukas@statuscode.ch>
Severity: Minor
Found in apps/federatedfilesharing/lib/Notifications.php - About 2 hrs to fix

    Function tryHttpPostToShareEndpoint has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function tryHttpPostToShareEndpoint($remoteDomain, $urlSuffix, array $fields, $useOcm = false) {
        $client = $this->httpClientService->newClient();
        $protocol = 'https://';
        $result = [
            'success' => false,
    Severity: Minor
    Found in apps/federatedfilesharing/lib/Notifications.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method tryHttpPostToShareEndpoint has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function tryHttpPostToShareEndpoint($remoteDomain, $urlSuffix, array $fields, $useOcm = false) {
        $client = $this->httpClientService->newClient();
        $protocol = 'https://';
        $result = [
            'success' => false,
    Severity: Minor
    Found in apps/federatedfilesharing/lib/Notifications.php - About 1 hr to fix

      Method requestReShare has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function requestReShare($token, $id, $shareId, $remote, $shareWith, $permission) {
        $data = [
            'shareWith' => $shareWith,
            'senderId' => $shareId
        ];
      Severity: Minor
      Found in apps/federatedfilesharing/lib/Notifications.php - About 1 hr to fix

        Method sendUpdateToRemote has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function sendUpdateToRemote($remote, $remoteId, $token, $action, $data = [], $try = 0) {
        $ocmNotification = $this->notificationManager->convertToOcmFileNotification($remoteId, $token, $action, $data);
        $ocmFields = $ocmNotification->toArray();
        $url = \rtrim(
            $this->addressHandler->removeProtocolFromUrl($remote),
        Severity: Minor
        Found in apps/federatedfilesharing/lib/Notifications.php - About 1 hr to fix

          Method sendRemoteShare has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function sendRemoteShare(
        Address $shareWithAddress,
        Address $ownerAddress,
        Address $sharedByAddress,
        $token,
          Severity: Minor
          Found in apps/federatedfilesharing/lib/Notifications.php - About 1 hr to fix

            Method sendRemoteShare has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    Address $shareWithAddress,
        Address $ownerAddress,
        Address $sharedByAddress,
        $token,
        $name,
            Severity: Minor
            Found in apps/federatedfilesharing/lib/Notifications.php - About 45 mins to fix

              Method sendUpdateToRemote has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function sendUpdateToRemote($remote, $remoteId, $token, $action, $data = [], $try = 0) {
              Severity: Minor
              Found in apps/federatedfilesharing/lib/Notifications.php - About 45 mins to fix

                Method requestReShare has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function requestReShare($token, $id, $shareId, $remote, $shareWith, $permission) {
                Severity: Minor
                Found in apps/federatedfilesharing/lib/Notifications.php - About 45 mins to fix

                  Method sendPreOcmRemoteShare has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      protected function sendPreOcmRemoteShare(Address $shareWithAddress, Address $ownerAddress, Address $sharedByAddress, $token, $name, $remote_id) {
                  Severity: Minor
                  Found in apps/federatedfilesharing/lib/Notifications.php - About 45 mins to fix

                    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            AddressHandler $addressHandler,
        IClientService $httpClientService,
        DiscoveryManager $discoveryManager,
        NotificationManager $notificationManager,
        IJobList $jobList,
                    Severity: Minor
                    Found in apps/federatedfilesharing/lib/Notifications.php - About 45 mins to fix

                      Method sendOcmRemoteShare has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          protected function sendOcmRemoteShare(Address $shareWithAddress, Address $ownerAddress, Address $sharedByAddress, $token, $name, $remote_id) {
                      Severity: Minor
                      Found in apps/federatedfilesharing/lib/Notifications.php - About 45 mins to fix

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                            public function __construct(
        AddressHandler $addressHandler,
        IClientService $httpClientService,
        DiscoveryManager $discoveryManager,
        NotificationManager $notificationManager,
                        Severity: Major
                        Found in apps/federatedfilesharing/lib/Notifications.php and 3 other locations - About 1 hr to fix
                        apps/files_sharing/lib/Capabilities.php on lines 70..84
                        lib/private/Authentication/TwoFactorAuth/Manager.php on lines 67..74
                        lib/private/License/LicenseManager.php on lines 46..60

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 100.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status