Sign upLogin

owncloud/core

View on GitHub
Star
apps/files/lib/Command/Scan.php

Summary

Maintainability
F
3 days
Test Coverage

File Scan.php has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @author Bart Visscher <bartv@thisnet.nl>
 * @author Jörn Friedrich Dreyer <jfd@butonic.de>
 * @author martin.mattel@diemattels.at <martin.mattel@diemattels.at>
Severity: Minor
Found in apps/files/lib/Command/Scan.php - About 5 hrs to fix

    Method scanFiles has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function scanFiles($user, $path, $verbose, OutputInterface $output, $backgroundScan = false, $shouldRepair = false) {
        $connection = $this->reconnectToDatabase($output);
        $scanner = new \OC\Files\Utils\Scanner($user, $connection, \OC::$server->getLogger());
        if ($shouldRepair) {
            $scanner->listen('\OC\Files\Utils\Scanner', 'beforeScanStorage', function ($storage) use ($output, $connection) {
    Severity: Major
    Found in apps/files/lib/Command/Scan.php - About 3 hrs to fix

      Function execute has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function execute(InputInterface $input, OutputInterface $output): int {
        $inputPath = $input->getOption('path');
        $groups = $input->getOption('groups') ? \explode(',', $input->getOption('groups')) : [];
        $groups = \array_unique(\array_merge($groups, $input->getOption('group')));
        $shouldRepairStoragesIndividually = (bool) $input->getOption('repair');
      Severity: Minor
      Found in apps/files/lib/Command/Scan.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method configure has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function configure() {
        parent::configure();

        $this
            ->setName('files:scan')
      Severity: Major
      Found in apps/files/lib/Command/Scan.php - About 2 hrs to fix

        Method execute has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function execute(InputInterface $input, OutputInterface $output): int {
        $inputPath = $input->getOption('path');
        $groups = $input->getOption('groups') ? \explode(',', $input->getOption('groups')) : [];
        $groups = \array_unique(\array_merge($groups, $input->getOption('group')));
        $shouldRepairStoragesIndividually = (bool) $input->getOption('repair');
        Severity: Minor
        Found in apps/files/lib/Command/Scan.php - About 1 hr to fix

          Function userScan has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function userScan($users, $inputPath, $shouldRepairStoragesIndividually, $input, $output, $verbose) {
        $users_total = \count($users);
        $user_count = 0;
        foreach ($users as $user) {
            if (\is_object($user)) {
          Severity: Minor
          Found in apps/files/lib/Command/Scan.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method processUserChunks has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function processUserChunks($input, $output, $users, $inputPath, $shouldRepairStoragesIndividually, $group = null) {
        # no messaging level option means: no full printout but statistics
        # $quiet   means no print at all
        # $verbose means full printout including statistics
        # -q    -v    full    stat
          Severity: Minor
          Found in apps/files/lib/Command/Scan.php - About 1 hr to fix

            Method userScan has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function userScan($users, $inputPath, $shouldRepairStoragesIndividually, $input, $output, $verbose) {
        $users_total = \count($users);
        $user_count = 0;
        foreach ($users as $user) {
            if (\is_object($user)) {
            Severity: Minor
            Found in apps/files/lib/Command/Scan.php - About 1 hr to fix

              Function processUserChunks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function processUserChunks($input, $output, $users, $inputPath, $shouldRepairStoragesIndividually, $group = null) {
        # no messaging level option means: no full printout but statistics
        # $quiet   means no print at all
        # $verbose means full printout including statistics
        # -q    -v    full    stat
              Severity: Minor
              Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method userScan has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  protected function userScan($users, $inputPath, $shouldRepairStoragesIndividually, $input, $output, $verbose) {
              Severity: Minor
              Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

                Function scanFiles has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function scanFiles($user, $path, $verbose, OutputInterface $output, $backgroundScan = false, $shouldRepair = false) {
        $connection = $this->reconnectToDatabase($output);
        $scanner = new \OC\Files\Utils\Scanner($user, $connection, \OC::$server->getLogger());
        if ($shouldRepair) {
            $scanner->listen('\OC\Files\Utils\Scanner', 'beforeScanStorage', function ($storage) use ($output, $connection) {
                Severity: Minor
                Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        IUserManager $userManager,
        IGroupManager $groupManager,
        ILockingProvider $lockingProvider,
        IMimeTypeLoader $mimeTypeLoader,
        ILogger $logger,
                Severity: Minor
                Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

                  Method scanFiles has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      protected function scanFiles($user, $path, $verbose, OutputInterface $output, $backgroundScan = false, $shouldRepair = false) {
                  Severity: Minor
                  Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

                    Method processUserChunks has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        protected function processUserChunks($input, $output, $users, $inputPath, $shouldRepairStoragesIndividually, $group = null) {
                    Severity: Minor
                    Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function __construct(
        IUserManager $userManager,
        IGroupManager $groupManager,
        ILockingProvider $lockingProvider,
        IMimeTypeLoader $mimeTypeLoader,
                      Severity: Major
                      Found in apps/files/lib/Command/Scan.php and 1 other location - About 1 hr to fix
                      apps/files/lib/Command/TransferOwnership.php on lines 91..106

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 107.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status