Sign upLogin

owncloud/core

View on GitHub
Star
apps/files/lib/Command/TransferOwnership.php

Summary

Maintainability
D
3 days
Test Coverage

Function collectUsersShares has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    private function collectUsersShares(InputInterface $input, OutputInterface $output) {
        $output->writeln("Collecting all share information for files and folder of $this->sourceUser ...");

        $skipped = 0;
        $progress = new ProgressBar($output, \count($this->shares));
Severity: Minor
Found in apps/files/lib/Command/TransferOwnership.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File TransferOwnership.php has 303 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @author Carla Schroder <carla@owncloud.com>
 * @author Joas Schilling <coding@schilljs.com>
 * @author Thomas Müller <thomas.mueller@tmit.eu>
Severity: Minor
Found in apps/files/lib/Command/TransferOwnership.php - About 3 hrs to fix

    Method execute has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output): int {
        $sourceUserObject = $this->userManager->get($input->getArgument('source-user'));
        $destinationUserObject = $this->userManager->get($input->getArgument('destination-user'));
        if ($sourceUserObject === null) {
            $output->writeln("<error>Unknown source user $this->sourceUser</error>");
    Severity: Major
    Found in apps/files/lib/Command/TransferOwnership.php - About 2 hrs to fix

      Function execute has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function execute(InputInterface $input, OutputInterface $output): int {
        $sourceUserObject = $this->userManager->get($input->getArgument('source-user'));
        $destinationUserObject = $this->userManager->get($input->getArgument('destination-user'));
        if ($sourceUserObject === null) {
            $output->writeln("<error>Unknown source user $this->sourceUser</error>");
      Severity: Minor
      Found in apps/files/lib/Command/TransferOwnership.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method collectUsersShares has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function collectUsersShares(InputInterface $input, OutputInterface $output) {
        $output->writeln("Collecting all share information for files and folder of $this->sourceUser ...");

        $skipped = 0;
        $progress = new ProgressBar($output, \count($this->shares));
      Severity: Minor
      Found in apps/files/lib/Command/TransferOwnership.php - About 1 hr to fix

        Function restoreShares has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            private function restoreShares(OutputInterface $output) {
        $output->writeln("Restoring shares ...");
        $progress = new ProgressBar($output, \count($this->shares));
        $status = 0;
        Severity: Minor
        Found in apps/files/lib/Command/TransferOwnership.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method analyse has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function analyse(OutputInterface $output) {
        $view = new View();
        $output->writeln("Analysing files of $this->sourceUser ...");
        $progress = new ProgressBar($output);
        $progress->start();
        Severity: Minor
        Found in apps/files/lib/Command/TransferOwnership.php - About 1 hr to fix

          Method configure has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function configure() {
        $this
            ->setName('files:transfer-ownership')
            ->setDescription('All files and folders are moved to another user - shares are moved as well.')
            ->addArgument(
          Severity: Minor
          Found in apps/files/lib/Command/TransferOwnership.php - About 1 hr to fix

            Method restoreShares has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function restoreShares(OutputInterface $output) {
        $output->writeln("Restoring shares ...");
        $progress = new ProgressBar($output, \count($this->shares));
        $status = 0;
            Severity: Minor
            Found in apps/files/lib/Command/TransferOwnership.php - About 1 hr to fix

              Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      IUserManager $userManager,
        IManager $shareManager,
        IMountManager $mountManager,
        IRootFolder $rootFolder,
        Manager $encryptionManager,
              Severity: Minor
              Found in apps/files/lib/Command/TransferOwnership.php - About 45 mins to fix

                Avoid too many return statements within this method.
                Open

                            return 1;
                Severity: Major
                Found in apps/files/lib/Command/TransferOwnership.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return 1;
                  Severity: Major
                  Found in apps/files/lib/Command/TransferOwnership.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return 1;
                    Severity: Major
                    Found in apps/files/lib/Command/TransferOwnership.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return $this->restoreShares($output);
                      Severity: Major
                      Found in apps/files/lib/Command/TransferOwnership.php - About 30 mins to fix

                        Function analyse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected function analyse(OutputInterface $output) {
        $view = new View();
        $output->writeln("Analysing files of $this->sourceUser ...");
        $progress = new ProgressBar($output);
        $progress->start();
                        Severity: Minor
                        Found in apps/files/lib/Command/TransferOwnership.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public function __construct(
        IUserManager $userManager,
        IManager $shareManager,
        IMountManager $mountManager,
        IRootFolder $rootFolder,
                        Severity: Major
                        Found in apps/files/lib/Command/TransferOwnership.php and 1 other location - About 1 hr to fix
                        apps/files/lib/Command/Scan.php on lines 72..87

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 107.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status