Sign upLogin

owncloud/core

View on GitHub
Star
apps/files_sharing/lib/AppInfo/Application.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method __construct has 122 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(array $urlParams = []) {
        parent::__construct('files_sharing', $urlParams);

        $container = $this->getContainer();
        $server = $container->getServer();
Severity: Major
Found in apps/files_sharing/lib/AppInfo/Application.php - About 4 hrs to fix

    Avoid too many return statements within this method.
    Open

                return new MountProvider(
                $server->getConfig(),
                $server->getShareManager(),
                $server->getLogger()
            );
    Severity: Major
    Found in apps/files_sharing/lib/AppInfo/Application.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return new \OCA\Files_Sharing\External\MountProvider(
                $server->getDatabaseConnection(),
                function () use ($c) {
                    return $c->query('ExternalManager');
                }
      Severity: Major
      Found in apps/files_sharing/lib/AppInfo/Application.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return new \OCA\Files_Sharing\External\Manager(
                $server->getDatabaseConnection(),
                \OC\Files\Filesystem::getMountManager(),
                \OC\Files\Filesystem::getLoader(),
                $server->getNotificationManager(),
        Severity: Major
        Found in apps/files_sharing/lib/AppInfo/Application.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $server->getHTTPClientService();
          Severity: Major
          Found in apps/files_sharing/lib/AppInfo/Application.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return new Hooks(
                $c->getServer()->getLazyRootFolder(),
                $c->getServer()->getUrlGenerator(),
                $c->getServer()->getEventDispatcher(),
                $c->getServer()->getShareManager(),
            Severity: Major
            Found in apps/files_sharing/lib/AppInfo/Application.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return new SharingCheckMiddleware(
                $c->query('AppName'),
                $server->getConfig(),
                $server->getAppManager(),
                $c['ControllerMethodReflector']
              Severity: Major
              Found in apps/files_sharing/lib/AppInfo/Application.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status