Sign upLogin

owncloud/core

View on GitHub
Star
apps/files_sharing/lib/Controller/ShareesController.php

Summary

Maintainability
F
5 days
Test Coverage

File ShareesController.php has 490 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @author Björn Schießle <bjoern@schiessle.org>
 * @author Joas Schilling <coding@schilljs.com>
 * @author Roeland Jago Douma <rullzer@owncloud.com>
Severity: Minor
Found in apps/files_sharing/lib/Controller/ShareesController.php - About 7 hrs to fix

    Function getRemote has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function getRemote($search) {
        $this->result['remotes'] = $this->result['exact']['remotes'] = $users = [];

        if (\strlen(\trim($search)) === 0 && $this->userSearch->getSearchMinLength() > 0) {
            $this->result['remotes'] = [];
    Severity: Minor
    Found in apps/files_sharing/lib/Controller/ShareesController.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getUsers has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function getUsers($search) {
        $this->result['users'] = $this->result['exact']['users'] = $users = [];

        if (\strlen(\trim($search)) === 0 && $this->userSearch->getSearchMinLength() > 0) {
            $this->result['users'] = [];
    Severity: Minor
    Found in apps/files_sharing/lib/Controller/ShareesController.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getRemote has 105 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getRemote($search) {
        $this->result['remotes'] = $this->result['exact']['remotes'] = $users = [];

        if (\strlen(\trim($search)) === 0 && $this->userSearch->getSearchMinLength() > 0) {
            $this->result['remotes'] = [];
    Severity: Major
    Found in apps/files_sharing/lib/Controller/ShareesController.php - About 4 hrs to fix

      Method getUsers has 91 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getUsers($search) {
        $this->result['users'] = $this->result['exact']['users'] = $users = [];

        if (\strlen(\trim($search)) === 0 && $this->userSearch->getSearchMinLength() > 0) {
            $this->result['users'] = [];
      Severity: Major
      Found in apps/files_sharing/lib/Controller/ShareesController.php - About 3 hrs to fix

        Function getGroups has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function getGroups($search) {
        $this->result['groups'] = $this->result['exact']['groups'] = [];

        if (\strlen(\trim($search)) === 0 && $this->userSearch->getSearchMinLength() > 0) {
            $this->result['groups'] = [];
        Severity: Minor
        Found in apps/files_sharing/lib/Controller/ShareesController.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getGroups has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function getGroups($search) {
        $this->result['groups'] = $this->result['exact']['groups'] = [];

        if (\strlen(\trim($search)) === 0 && $this->userSearch->getSearchMinLength() > 0) {
            $this->result['groups'] = [];
        Severity: Major
        Found in apps/files_sharing/lib/Controller/ShareesController.php - About 2 hrs to fix

          Method search has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function search($search = '', $itemType = null, $page = 1, $perPage = 200) {
        if ($perPage <= 0) {
            return [ 'statuscode' => Http::STATUS_BAD_REQUEST,
                'message' => 'Invalid perPage argument'];
        }
          Severity: Minor
          Found in apps/files_sharing/lib/Controller/ShareesController.php - About 1 hr to fix

            Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $appName,
        IRequest $request,
        IGroupManager $groupManager,
        IUserManager $userManager,
        IManager $contactsManager,
            Severity: Major
            Found in apps/files_sharing/lib/Controller/ShareesController.php - About 1 hr to fix

              Method splitUserRemote has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function splitUserRemote($address) {
        if (\strpos($address, '@') === false) {
            throw new \Exception('Invalid Federated Cloud ID');
        }
              Severity: Minor
              Found in apps/files_sharing/lib/Controller/ShareesController.php - About 1 hr to fix

                Function search has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function search($search = '', $itemType = null, $page = 1, $perPage = 200) {
        if ($perPage <= 0) {
            return [ 'statuscode' => Http::STATUS_BAD_REQUEST,
                'message' => 'Invalid perPage argument'];
        }
                Severity: Minor
                Found in apps/files_sharing/lib/Controller/ShareesController.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function splitUserRemote has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function splitUserRemote($address) {
        if (\strpos($address, '@') === false) {
            throw new \Exception('Invalid Federated Cloud ID');
        }
                Severity: Minor
                Found in apps/files_sharing/lib/Controller/ShareesController.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Consider simplifying this complex logical expression.
                Open

                        if (!$foundRemoteById && \substr_count($search, '@') >= 1
            && $this->offset === 0 && $this->userSearch->isSearchable($search)
            // if an exact local user is found, only keep the remote entry if
            // its domain does not match the trusted domains
            // (if it does, it is a user whose local login domain matches the ownCloud
                Severity: Major
                Found in apps/files_sharing/lib/Controller/ShareesController.php - About 40 mins to fix

                  Method searchSharees has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      protected function searchSharees($search, $itemType, array $shareTypes, $page, $perPage) {
                  Severity: Minor
                  Found in apps/files_sharing/lib/Controller/ShareesController.php - About 35 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ($pos !== false) {
            $user = \substr($id, 0, $pos);
            $remote = \substr($id, $pos + 1);
            $remote = $this->fixRemoteURL($remote);
            if (!empty($user) && !empty($remote)) {
                    Severity: Minor
                    Found in apps/files_sharing/lib/Controller/ShareesController.php and 1 other location - About 40 mins to fix
                    apps/federatedfilesharing/lib/AddressHandler.php on lines 89..96

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 93.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                            if ($posSlash === false && $posColon === false) {
            $invalidPos = \strlen($id);
        } elseif ($posSlash === false) {
            $invalidPos = $posColon;
        } elseif ($posColon === false) {
                    Severity: Minor
                    Found in apps/files_sharing/lib/Controller/ShareesController.php and 2 other locations - About 40 mins to fix
                    apps/federatedfilesharing/lib/AddressHandler.php on lines 72..80
                    lib/private/Share/Helper.php on lines 258..266

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 93.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status