Sign upLogin

owncloud/core

View on GitHub
Star
apps/files_sharing/lib/Controllers/ShareController.php

Summary

Maintainability
D
3 days
Test Coverage

Function downloadShare has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    public function downloadShare($token, $files = null, $path = '', $downloadStartSecret = '') {
        \OC_User::setIncognitoMode(true);

        $share = $this->shareManager->getShareByToken($token);
Severity: Minor
Found in apps/files_sharing/lib/Controllers/ShareController.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ShareController.php has 349 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
 * @author Björn Schießle <bjoern@schiessle.org>
 * @author Georg Ehrke <georg@owncloud.com>
Severity: Minor
Found in apps/files_sharing/lib/Controllers/ShareController.php - About 4 hrs to fix

    Method downloadShare has 99 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function downloadShare($token, $files = null, $path = '', $downloadStartSecret = '') {
        \OC_User::setIncognitoMode(true);

        $share = $this->shareManager->getShareByToken($token);
    Severity: Major
    Found in apps/files_sharing/lib/Controllers/ShareController.php - About 3 hrs to fix

      Method showShare has 98 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function showShare($token, $path = '') {
        \OC_User::setIncognitoMode(true);

        // Check whether share exists
        try {
      Severity: Major
      Found in apps/files_sharing/lib/Controllers/ShareController.php - About 3 hrs to fix

        Function showShare has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

            public function showShare($token, $path = '') {
        \OC_User::setIncognitoMode(true);

        // Check whether share exists
        try {
        Severity: Minor
        Found in apps/files_sharing/lib/Controllers/ShareController.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 13 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $appName,
        IRequest $request,
        IConfig $config,
        IURLGenerator $urlGenerator,
        IUserManager $userManager,
        Severity: Major
        Found in apps/files_sharing/lib/Controllers/ShareController.php - About 1 hr to fix

          Method emitAccessShareHook has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function emitAccessShareHook($share, $errorCode = 200, $errorMessage = '') {
        $itemType = $itemSource = $uidOwner = '';
        $token = $share;
        $exception = null;
        if ($share instanceof \OCP\Share\IShare) {
          Severity: Minor
          Found in apps/files_sharing/lib/Controllers/ShareController.php - About 1 hr to fix

            Function linkShareAuth has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function linkShareAuth(\OCP\Share\IShare $share, $password = null) {
        $beforeEvent = new GenericEvent(null, ['shareObject' => $share]);
        $this->eventDispatcher->dispatch($beforeEvent, 'share.beforelinkauth');
        if ($password !== null) {
            if ($this->shareManager->checkPassword($share, $password)) {
            Severity: Minor
            Found in apps/files_sharing/lib/Controllers/ShareController.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        } else {
                // The folder is downloaded
                $event = $this->activityManager->generateEvent();
                $event->setApp('files_sharing')
                    ->setType(Activity::TYPE_PUBLIC_LINKS)
            Severity: Minor
            Found in apps/files_sharing/lib/Controllers/ShareController.php and 1 other location - About 1 hr to fix
            apps/files_sharing/lib/Controllers/ShareController.php on lines 481..520

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if ($node instanceof \OCP\Files\File) {
                // Single file download
                $event = $this->activityManager->generateEvent();
                $event->setApp('files_sharing')
                    ->setType(Activity::TYPE_PUBLIC_LINKS)
            Severity: Minor
            Found in apps/files_sharing/lib/Controllers/ShareController.php and 1 other location - About 1 hr to fix
            apps/files_sharing/lib/Controllers/ShareController.php on lines 511..520

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status