File Manager.php has 385 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/**
 * @author Björn Schießle <bjoern@schiessle.org>
 * @author Joas Schilling <coding@schilljs.com>
 * @author Jörn Friedrich Dreyer <jfd@butonic.de>

Manager has 23 functions (exceeds 20 allowed). Consider refactoring.

Open

class Manager {
    public const STORAGE = '\OCA\Files_Sharing\External\Storage';

    /**
     * @var string

Method addShare has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function addShare($remote, $token, $password, $name, $owner, $accepted = false, $user = null, $remoteId = -1) {
        $user = $user ? $user : $this->uid;
        $accepted = $accepted ? 1 : 0;
        $name = Filesystem::normalizePath('/' . $name);

Function testRemoteUrl has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.

Open

    public function testRemoteUrl(IClientService $clientService, string $remote) {
        $parsed_host = parse_url($remote, PHP_URL_HOST);
        $parsed_port = parse_url($remote, PHP_URL_PORT);
        if (\is_string($parsed_host)) {
            $remote = $parsed_host;

• Read up
  Read up

Method testRemoteUrl has 39 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function testRemoteUrl(IClientService $clientService, string $remote) {
        $parsed_host = parse_url($remote, PHP_URL_HOST);
        $parsed_port = parse_url($remote, PHP_URL_PORT);
        if (\is_string($parsed_host)) {
            $remote = $parsed_host;

Method removeShare has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function removeShare($mountPoint) {
        if ($this->uid === null) {
            throw new NoUserException();
        }

Method acceptShare has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function acceptShare($id) {
        $share = $this->getShare($id);

        if ($share) {
            $mountPoint = $this->getShareRecipientMountPoint($share);

Method addShare has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function addShare($remote, $token, $password, $name, $owner, $accepted = false, $user = null, $remoteId = -1) {

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

        \OCP\IDBConnection                 $connection,
        \OC\Files\Mount\Manager            $mountManager,
        \OCP\Files\Storage\IStorageFactory $storageLoader,
        IManager                           $notificationManager,
        EventDispatcherInterface           $eventDispatcher,

Function testUrl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    protected function testUrl(IClientService $clientService, string $remote, bool $checkVersion = false, bool $throwConnectException = false): bool {
        try {
            $client = $clientService->newClient();
            $response = \json_decode($client->get(
                $remote,

• Read up
  Read up