Sign upLogin

owncloud/core

View on GitHub
Star
apps/files_sharing/lib/External/ScanExternalSharesJob.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method scan has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function scan($share) {
        // get mount
        $options = [
            'remote'    => $share['remote'],
            'token'        => $share['share_token'],
Severity: Minor
Found in apps/files_sharing/lib/External/ScanExternalSharesJob.php - About 1 hr to fix

    Method run has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function run($argument) {
        $enabled = $this->config->getAppValue('files_sharing', 'cronjob_scan_external_enabled', 'no');
        if ($enabled !== 'yes') {
            $this->logger->debug(
                "Fed share scanner disabled, ignoring the run"
    Severity: Minor
    Found in apps/files_sharing/lib/External/ScanExternalSharesJob.php - About 1 hr to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              IDBConnection $connection = null,
        IConfig $config = null,
        IUserManager $userManager = null,
        ILogger $logger = null,
        Manager $externalManager = null
      Severity: Minor
      Found in apps/files_sharing/lib/External/ScanExternalSharesJob.php - About 35 mins to fix

        Function run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function run($argument) {
        $enabled = $this->config->getAppValue('files_sharing', 'cronjob_scan_external_enabled', 'no');
        if ($enabled !== 'yes') {
            $this->logger->debug(
                "Fed share scanner disabled, ignoring the run"
        Severity: Minor
        Found in apps/files_sharing/lib/External/ScanExternalSharesJob.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status