Sign upLogin

owncloud/core

View on GitHub
Star
apps/files_sharing/lib/SharedStorage.php

Summary

Maintainability
D
1 day
Test Coverage

SharedStorage has 36 functions (exceeds 20 allowed). Consider refactoring.
Open

class SharedStorage extends \OC\Files\Storage\Wrapper\Jail implements ISharedStorage {
    /** @var \OCP\Share\IShare */
    private $superShare;

    /** @var \OCP\Share\IShare[] */
Severity: Minor
Found in apps/files_sharing/lib/SharedStorage.php - About 4 hrs to fix

    File SharedStorage.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * @author Bart Visscher <bartv@thisnet.nl>
 * @author Björn Schießle <bjoern@schiessle.org>
 * @author Joas Schilling <coding@schilljs.com>
    Severity: Minor
    Found in apps/files_sharing/lib/SharedStorage.php - About 2 hrs to fix

      Method fopen has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function fopen($path, $mode) {
        if ($source = $this->getSourcePath($path)) {
            switch ($mode) {
                case 'r+':
                case 'rb+':
      Severity: Minor
      Found in apps/files_sharing/lib/SharedStorage.php - About 1 hr to fix

        Function fopen has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function fopen($path, $mode) {
        if ($source = $this->getSourcePath($path)) {
            switch ($mode) {
                case 'r+':
                case 'rb+':
        Severity: Minor
        Found in apps/files_sharing/lib/SharedStorage.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function rename has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function rename($path1, $path2) {
        $isPartFile = \pathinfo($path1, PATHINFO_EXTENSION) === 'part';
        $targetExists = $this->file_exists($path2);
        $sameFolder = \dirname($path1) === \dirname($path2);
        Severity: Minor
        Found in apps/files_sharing/lib/SharedStorage.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return false;
        Severity: Major
        Found in apps/files_sharing/lib/SharedStorage.php - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function acquireLock($path, $type, ILockingProvider $provider) {
        /** @var \OCP\Files\Storage $targetStorage */
        list($targetStorage, $targetInternalPath) = $this->resolvePath($path);
        $targetStorage->acquireLock($targetInternalPath, $type, $provider);
        // lock the parent folders of the owner when locking the share as recipient
          Severity: Major
          Found in apps/files_sharing/lib/SharedStorage.php and 1 other location - About 1 hr to fix
          apps/files_sharing/lib/SharedStorage.php on lines 392..401

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 113.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function releaseLock($path, $type, ILockingProvider $provider) {
        /** @var \OCP\Files\Storage $targetStorage */
        list($targetStorage, $targetInternalPath) = $this->resolvePath($path);
        $targetStorage->releaseLock($targetInternalPath, $type, $provider);
        // unlock the parent folders of the owner when unlocking the share as recipient
          Severity: Major
          Found in apps/files_sharing/lib/SharedStorage.php and 1 other location - About 1 hr to fix
          apps/files_sharing/lib/SharedStorage.php on lines 376..385

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 113.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status