Sign upLogin

owncloud/core

View on GitHub
Star
apps/files_sharing/lib/ViewOnly.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function check has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function check($pathsToCheck) {
        // If any of elements cannot be downloaded, prevent whole download
        foreach ($pathsToCheck as $file) {
            try {
                $info = $this->userFolder->get($file);
Severity: Minor
Found in apps/files_sharing/lib/ViewOnly.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dirRecursiveCheck has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private function dirRecursiveCheck(Folder $dirInfo) {
        if (!$this->checkFileInfo($dirInfo)) {
            return false;
        }
        // If any of elements cannot be downloaded, prevent whole download
Severity: Minor
Found in apps/files_sharing/lib/ViewOnly.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status