Sign upLogin

owncloud/core

View on GitHub
Star
apps/provisioning_api/lib/Groups.php

Summary

Maintainability
A
1 hr
Test Coverage

Avoid too many return statements within this method.
Open

        return new OC_OCS_Result(null, 997);
Severity: Major
Found in apps/provisioning_api/lib/Groups.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return new OC_OCS_Result(null, \OCP\API::RESPOND_UNAUTHORISED, 'User does not have access to specified group');
    Severity: Major
    Found in apps/provisioning_api/lib/Groups.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return new OC_OCS_Result(null, 100);
      Severity: Major
      Found in apps/provisioning_api/lib/Groups.php - About 30 mins to fix

        Function addGroup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function addGroup($parameters) {
        // Validate name
        $groupId = $this->request->getParam('groupid', '');
        if (($groupId === '') || $groupId === null || ($groupId === false)) {
            \OCP\Util::writeLog('provisioning_api', 'Group name not supplied', \OCP\Util::ERROR);
        Severity: Minor
        Found in apps/provisioning_api/lib/Groups.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status