Sign upLogin

owncloud/core

View on GitHub
Star
core/Command/Upgrade.php

Summary

Maintainability
D
2 days
Test Coverage

Method execute has 186 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output): int {
        if ($output->getVerbosity() === OutputInterface::VERBOSITY_NORMAL
            && !$input->hasParameterOption('--verbose=0', true)) {
            // set to more verbose on upgrade if no explicit verbosity was set
            $output->setVerbosity(OutputInterface::VERBOSITY_VERBOSE);
Severity: Major
Found in core/Command/Upgrade.php - About 7 hrs to fix

    Function execute has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output): int {
        if ($output->getVerbosity() === OutputInterface::VERBOSITY_NORMAL
            && !$input->hasParameterOption('--verbose=0', true)) {
            // set to more verbose on upgrade if no explicit verbosity was set
            $output->setVerbosity(OutputInterface::VERBOSITY_VERBOSE);
    Severity: Minor
    Found in core/Command/Upgrade.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Upgrade.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * @author Andreas Fischer <bantu@owncloud.com>
 * @author Björn Schießle <bjoern@schiessle.org>
 * @author Joas Schilling <coding@schilljs.com>
    Severity: Minor
    Found in core/Command/Upgrade.php - About 2 hrs to fix

      Method printAdvisory has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function printAdvisory(OutputInterface $output):void {
        $heading = <<<EOT

  ______             __    __      __                      __         ______   __                        __     
 /      \           /  |  /  |    /  |                    /  |       /      \ /  |                      /  |
      Severity: Minor
      Found in core/Command/Upgrade.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return self::ERROR_UP_TO_DATE;
        Severity: Major
        Found in core/Command/Upgrade.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status