Method postAvatar
has 94 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function postAvatar($path) {
$userId = $this->userSession->getUser()->getUID();
$files = $this->request->getUploadedFile('files');
$tmpImage = null;
Function postAvatar
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
public function postAvatar($path) {
$userId = $this->userSession->getUser()->getUID();
$files = $this->request->getUploadedFile('files');
$tmpImage = null;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File AvatarController.php
has 251 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @author Joas Schilling <coding@schilljs.com>
* @author Lukas Reschke <lukas@statuscode.ch>
* @author Martin Mattel <martin.mattel@diemattels.at>
Method postCroppedAvatar
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function postCroppedAvatar($crop) {
$userId = $this->userSession->getUser()->getUID();
if ($crop === null) {
return new DataResponse(
Method getAvatar
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getAvatar($userId, $size) {
if ($size > 2048) {
$size = 2048;
} elseif ($size <= 0) {
$size = 64;
Method __construct
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
$appName,
IRequest $request,
IAvatarManager $avatarManager,
File $cache,
IL10N $l10n,
Avoid too many return
statements within this method. Open
return new DataResponse(['data' => ['message' => $this->l->t('An error occurred. Please contact your admin.')]], Http::STATUS_BAD_REQUEST);
Avoid too many return
statements within this method. Open
return new DataResponse(
['data' => ['message' => $this->l->t('No image or file provided')]],
Http::STATUS_BAD_REQUEST,
$headers
);
Avoid too many return
statements within this method. Open
return new DataResponse(
['data' => 'notsquare'],
Http::STATUS_OK,
$headers
);
Avoid too many return
statements within this method. Open
return new DataResponse(['data' => ['message' => $this->l->t('An error occurred. Please contact your admin.')]], Http::STATUS_OK, $headers);
Avoid too many return
statements within this method. Open
return new DataResponse(
['data' => ['message' => $this->l->t('Crop is not square')]],
Http::STATUS_BAD_REQUEST
);
Avoid too many return
statements within this method. Open
return new DataResponse(
['data' => ['message' => $this->l->t('Unknown filetype')]],
Http::STATUS_OK,
$headers
);
Avoid too many return
statements within this method. Open
return new DataResponse(
['data' => ['message' => $this->l->t('Image too large')]],
Http::STATUS_OK,
$headers
);
Avoid too many return
statements within this method. Open
return new DataResponse(
['data' => ['message' => $this->l->t('Invalid image')]],
Http::STATUS_OK,
$headers
);
Similar blocks of code found in 5 locations. Consider refactoring. Open
public function __construct(
$appName,
IRequest $request,
IAvatarManager $avatarManager,
File $cache,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 140.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76