Sign upLogin

owncloud/core

View on GitHub
Star
core/Controller/LoginController.php

Summary

Maintainability
D
2 days
Test Coverage

Function showLoginForm has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    public function showLoginForm($user, $redirect_url, $remember_login) {
        // check if there is apache auth backend available and try to obtain session,
        // if apache backend not registered or failed to login, proceed with show login form
        if ($this->handleApacheAuth()) {
            // apache auth was completed server-side and there is active session,
Severity: Minor
Found in core/Controller/LoginController.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method showLoginForm has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function showLoginForm($user, $redirect_url, $remember_login) {
        // check if there is apache auth backend available and try to obtain session,
        // if apache backend not registered or failed to login, proceed with show login form
        if ($this->handleApacheAuth()) {
            // apache auth was completed server-side and there is active session,
Severity: Major
Found in core/Controller/LoginController.php - About 3 hrs to fix

    Function tryLogin has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public function tryLogin($user, $password, $redirect_url, $timezone = null, $remember_login = null) {
        $originalUser = $user;
        // TODO: Add all the insane error handling
        $loginResult = $this->userSession->login($user, $password);
        if ($loginResult !== true && $this->config->getSystemValue('strict_login_enforced', false) !== true) {
    Severity: Minor
    Found in core/Controller/LoginController.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method tryLogin has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function tryLogin($user, $password, $redirect_url, $timezone = null, $remember_login = null) {
        $originalUser = $user;
        // TODO: Add all the insane error handling
        $loginResult = $this->userSession->login($user, $password);
        if ($loginResult !== true && $this->config->getSystemValue('strict_login_enforced', false) !== true) {
    Severity: Minor
    Found in core/Controller/LoginController.php - About 1 hr to fix

      Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $appName,
        IRequest $request,
        IUserManager $userManager,
        IConfig $config,
        ISession $session,
      Severity: Major
      Found in core/Controller/LoginController.php - About 1 hr to fix

        Method tryLogin has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function tryLogin($user, $password, $redirect_url, $timezone = null, $remember_login = null) {
        Severity: Minor
        Found in core/Controller/LoginController.php - About 35 mins to fix

          Avoid too many return statements within this method.
          Open

                  return new RedirectResponse($this->getDefaultUrl());
          Severity: Major
          Found in core/Controller/LoginController.php - About 30 mins to fix

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function __construct(
        $appName,
        IRequest $request,
        IUserManager $userManager,
        IConfig $config,
            Severity: Major
            Found in core/Controller/LoginController.php and 4 other locations - About 2 hrs to fix
            apps/federatedfilesharing/lib/Controller/OcmController.php on lines 96..116
            apps/files_sharing/lib/Controller/NotificationController.php on lines 54..73
            apps/updatenotification/lib/Controller/AdminController.php on lines 67..86
            core/Controller/AvatarController.php on lines 85..105

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 140.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status