Sign upLogin

owncloud/core

View on GitHub
Star
core/Controller/LostController.php

Summary

Maintainability
C
1 day
Test Coverage

Method sendEmail has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function sendEmail($user, $token, $link) {
        if ($this->userManager->userExists($user)) {
            $userObject = $this->userManager->get($user);
            $email = $userObject->getEMailAddress();
Severity: Major
Found in core/Controller/LostController.php - About 2 hrs to fix

    Method __construct has 14 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $appName,
        IRequest $request,
        IURLGenerator $urlGenerator,
        IUserManager $userManager,
        OC_Defaults $defaults,
    Severity: Major
    Found in core/Controller/LostController.php - About 1 hr to fix

      Function sendEmail has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function sendEmail($user, $token, $link) {
        if ($this->userManager->userExists($user)) {
            $userObject = $this->userManager->get($user);
            $email = $userObject->getEMailAddress();
      Severity: Minor
      Found in core/Controller/LostController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in core/Controller/LostController.php - About 30 mins to fix

        Function email has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function email($user) {
        try {
            $userObject = $this->userManager->get($user);
            if ($userObject === null) {
                $users = $this->userManager->getByEmail($user);
        Severity: Minor
        Found in core/Controller/LostController.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    try {
                $message = $this->mailer->createMessage();
                $message->setTo([$email => $name]);
                $message->setSubject($this->l10n->t('%s password changed successfully', [$this->defaults->getName()]));
                $message->setPlainBody($msgAlt);
        Severity: Major
        Found in core/Controller/LostController.php and 1 other location - About 1 hr to fix
        core/Controller/LostController.php on lines 376..388

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                try {
            $message = $this->mailer->createMessage();
            $message->setTo([$email => $name]);
            $message->setSubject($this->l10n->t('%s password reset', [$this->defaults->getName()]));
            $message->setPlainBody($msgAlt);
        Severity: Major
        Found in core/Controller/LostController.php and 1 other location - About 1 hr to fix
        core/Controller/LostController.php on lines 290..302

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status