owncloud/core

View on GitHub
core/Migrations/Version20170101010100.php

Summary

Maintainability
F
1 wk
Test Coverage

Method changeSchema has 984 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function changeSchema(Schema $schema, array $options) {
        $prefix = $options['tablePrefix'];

        if (!$schema->hasTable("{$prefix}addressbookchanges")) {
            $addressBookChangesTable = $schema->createTable("{$prefix}addressbookchanges");
Severity: Major
Found in core/Migrations/Version20170101010100.php - About 4 days to fix

    File Version20170101010100.php has 993 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * @author Philipp Schaffrath <pschaffrath@owncloud.com>
     *
     * @copyright Copyright (c) 2018, ownCloud GmbH
    Severity: Major
    Found in core/Migrations/Version20170101010100.php - About 2 days to fix

      Function changeSchema has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function changeSchema(Schema $schema, array $options) {
              $prefix = $options['tablePrefix'];
      
              if (!$schema->hasTable("{$prefix}addressbookchanges")) {
                  $addressBookChangesTable = $schema->createTable("{$prefix}addressbookchanges");
      Severity: Minor
      Found in core/Migrations/Version20170101010100.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status