owncloud/core

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        IDBConnection $connection,
        IL10N $l,
        IClientService $clientService,
        ILogger $logger,
        IJobList $jobList,

Method addShareToDB has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private function addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $uidOwner, $permissions, $expiration, $token) {

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        IConfig $config,
        ILogger $logger,
        IDBConnection $databaseConnection,
        IUserSession $userSession,
        IMountManager $mountManager,

Consider simplifying this complex logical expression.

Open

            if (\OC_User::handleApacheAuth() ||
                //Fix for broken webdav clients
                ($this->userSession->isLoggedIn() && $this->session->get(self::DAV_AUTHENTICATED) === null) ||
                //Well behaved clients that only send the cookie are allowed
                ($this->userSession->isLoggedIn() && $this->session->get(self::DAV_AUTHENTICATED) === $this->userSession->getUser()->getUID() && ($request->getHeader('Authorization') === null || $request->getHeader('Authorization') === ''))

Method create has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $mountPoint,
        $backend,
        $authMechanism,
        $backendOptions,
        $mountOptions,

Method createStorage has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $mountPoint,
        $backend,
        $authMechanism,
        $backendOptions,
        $mountOptions = null,

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        Tree $tree,
        View $view,
        ISystemTagManager $tagManager,
        ISystemTagObjectMapper $tagMapper,
        ITagManager $fileTagger,

Method shareItem has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public static function shareItem($itemType, $itemSource, $shareType, $shareWith, $permissions, $itemSourceName = null, \DateTime $expirationDate = null, $passwordChanged = null) {

Method createStorage has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $mountPoint,
        $backendIdentifier,
        $authMechanismIdentifier,
        $backendOptions,
        $mountOptions = null,

Method register has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $method,
        $url,
        $action,
        $app,
        $authLevel = self::USER_AUTH,

Method createStorage has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $mountPoint,
        $backendIdentifier,
        $authMechanismIdentifier,
        $backendOptions,
        $mountOptions = null,

Method checkReshare has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private static function checkReshare($itemType, $itemSource, $shareType, $shareWith, $uidOwner, $permissions, $itemSourceName, $expirationDate) {

Method shareItem has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public static function shareItem($itemType, $itemSource, $shareType, $shareWith, $permissions, $itemSourceName = null, \DateTime $expirationDate = null, $passwordChanged = null) {

Consider simplifying this complex logical expression.

Open

        if ($dateInterval->y == 0 && $dateInterval->m == 0 && $dateInterval->d == 0) {
            return (string) $l->t('today');
        } elseif ($dateInterval->y == 0 && $dateInterval->m == 0 && $dateInterval->d == 1) {
            return (string) $l->t('yesterday');
        } elseif ($dateInterval->y == 0 && $dateInterval->m == 0) {

Method register has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $method,
        $url,
        $action,
        $app,
        $authLevel = API::USER_AUTH,

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        Account $account,
        AccountMapper $mapper,
        $emitter = null,
        IConfig $config = null,
        $urlGenerator = null,

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        $qb = $qb->select('s.*')
            ->from('share', 's')
            ->leftJoin('s', 'filecache', 'f', $qb->expr()->eq('s.file_source', 'f.fileid'))
            ->where($qb->expr()->isNull('f.fileid'))
            ->andWhere(

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    public function __construct(
        IManager $shareManager,
        IConfig $config,
        UserSearch $userSearch,
        IL10N $l10n,

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    public function __construct(
        LicenseFetcher $licenseFetcher,
        MessageService $messageService,
        IAppManager $appManager,
        IConfig $config,

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    public function __construct(
        AddressHandler $addressHandler,
        IClientService $httpClientService,
        DiscoveryManager $discoveryManager,
        NotificationManager $notificationManager,

• Read up
  Read up