owncloud/core

View on GitHub

Showing 4,504 of 4,504 total issues

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        IUserManager $userManager,
        IGroupManager $groupManager,
        ILockingProvider $lockingProvider,
        IMimeTypeLoader $mimeTypeLoader,
        ILogger $logger,
Severity: Minor
Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

    Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct($params) {
            // extract context path from host if specified
            // (owncloud install path on host)
            $host = $params['host'];
            // strip protocol
    Severity: Minor
    Found in apps/files_external/lib/Lib/Storage/OwnCloud.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function readMetaFile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function readMetaFile(string $diskPath) {
            if (!\file_exists($diskPath)) {
                return [];
            }
    
    
    Severity: Minor
    Found in apps/files_versions/lib/MetaStorage.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method processUserChunks has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function processUserChunks($input, $output, $users, $inputPath, $shouldRepairStoragesIndividually, $group = null) {
    Severity: Minor
    Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

      Method getItemsSharedWithUser has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $itemType,
              $user,
              $format = self::FORMAT_NONE,
              $parameters = null,
              $limit = -1,
      Severity: Minor
      Found in lib/public/Share.php - About 45 mins to fix

        Function getStatusInfo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function getStatusInfo($includeVersion = false, $serverHide = false, $hostnameShort = false) {
                $systemConfig = \OC::$server->getSystemConfig();
        
                $installed = (bool) $systemConfig->getValue('installed', false);
                $maintenance = (bool) $systemConfig->getValue('maintenance', false);
        Severity: Minor
        Found in lib/public/Util.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getSharesBy has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function getSharesBy($userId, $shareType, $path = null, $reshares = false, $limit = 50, $offset = 0);
        Severity: Minor
        Found in lib/public/Share/IManager.php - About 45 mins to fix

          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function __construct(IFactory $languageFactory, IURLGenerator $URLGenerator, IManager $activityManager, ActivityHelper $helper, IDBConnection $connection, IConfig $config) {
          Severity: Minor
          Found in apps/files/lib/Activity.php - About 45 mins to fix

            Method translate has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function translate($app, $text, $params, $stripPath, $highlightParams, $languageCode);
            Severity: Minor
            Found in lib/public/Activity/IManager.php - About 45 mins to fix

              Function getFullDomain has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function getFullDomain($url) {
                      $parts = \parse_url($url);
                      if ($parts === false) {
                          throw new \InvalidArgumentException('Invalid url "' . $url . '"');
                      }
              Severity: Minor
              Found in lib/public/Util.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function loadPanels has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function loadPanels($type) {
                      // If already loaded just return
                      if (!empty($this->panels[$type])) {
                          return $this->panels[$type];
                      }
              Severity: Minor
              Found in lib/private/Settings/SettingsManager.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method begin has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function begin($path, $user, $mode, array $header, array $accessList, $sourceFileOfRename);
              Severity: Minor
              Found in lib/public/Encryption/IEncryptionModule.php - About 45 mins to fix

                Function checkConfig has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function checkConfig() {
                        $l = \OC::$server->getL10N('lib');
                
                        // Create config if it does not already exist
                        $configFilePath = self::$configDir .'/config.php';
                Severity: Minor
                Found in lib/kernel.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        IAppManager $appManager = null,
                        IURLGenerator $urlGenerator = null,
                        IFactory $l10nFac = null,
                        IUserSession $userSession = null,
                        IGroupManager $groupManager = null,
                Severity: Minor
                Found in lib/private/NavigationManager.php - About 45 mins to fix

                  Method translate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function translate($app, $text, $params, $stripPath, $highlightParams, $languageCode);
                  Severity: Minor
                  Found in lib/public/Activity/IExtension.php - About 45 mins to fix

                    Method getSharesBy has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function getSharesBy($userId, $shareType, $node, $reshares, $limit, $offset);
                    Severity: Minor
                    Found in lib/public/Share/IShareProvider.php - About 45 mins to fix

                      Method translate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function translate($app, $text, $params, $stripPath, $highlightParams, $languageCode) {
                      Severity: Minor
                      Found in apps/files/lib/Activity.php - About 45 mins to fix

                        Function sendMail has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public static function sendMail(
                                $toaddress,
                                $toname,
                                $subject,
                                $mailtext,
                        Severity: Minor
                        Found in lib/public/Util.php - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function __construct($gid, $backends, $userManager, EventDispatcherInterface $eventDispatcher, $emitter = null, $displayName = null) {
                        Severity: Minor
                        Found in lib/private/Group/Group.php - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                      if ($user !== null && \in_array($user->getUID(), $logCondition['users'], true)) {
                                                          $this->logConditionSatisfied = true;
                                                          if (!empty($logCondition['logfile'])) {
                                                              $logConditionFile = $logCondition['logfile'];
                                                          }
                          Severity: Major
                          Found in lib/private/Log.php - About 45 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language