Sign upLogin

owncloud/core

View on GitHub
Star

Showing 4,504 of 4,504 total issues

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct(IConfig $config, ILogger $logger, IUserManager $manager, ISession $session, ITimeFactory $timeFactory) {
Severity: Minor
Found in lib/private/User/BasicAuthModule.php - About 35 mins to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            IConfig $config,
        ILogger $logger,
        AccountMapper $accountMapper,
        SyncService $syncService,
        UserSearch $userSearch
    Severity: Minor
    Found in lib/private/User/Manager.php - About 35 mins to fix

      Method callForUsers has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function callForUsers($callback, $search, $onlySeen, $limit = null, $offset = null) {
      Severity: Minor
      Found in lib/private/User/AccountMapper.php - About 35 mins to fix

        Method convertDB has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected function convertDB(Connection $fromDB, Connection $toDB, array $tables, InputInterface $input, OutputInterface $output) {
        Severity: Minor
        Found in core/Command/Db/ConvertType.php - About 35 mins to fix

          Method writeArrayInOutputFormat has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              protected function writeArrayInOutputFormat(InputInterface $input, OutputInterface $output, $items, $prefix = self::DEFAULT_OUTPUT_PREFIX, $showIntKeys = false) {
          Severity: Minor
          Found in core/Command/Base.php - About 35 mins to fix

            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    IManager $encryptionManager,
        IAppManager $appManager,
        IConfig $config,
        \OC\Encryption\DecryptAll $decryptAll,
        QuestionHelper $questionHelper
            Severity: Minor
            Found in core/Command/Encryption/DecryptAll.php - About 35 mins to fix

              Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function __construct(View $view, IUserManager $userManager, IConfig $config, Util $util, QuestionHelper $questionHelper) {
              Severity: Minor
              Found in core/Command/Encryption/ChangeKeyStorageRoot.php - About 35 mins to fix

                Method writeJsonFile has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    private function writeJsonFile($path, $lang, OutputInterface $output, $translations, $plurals) {
                Severity: Minor
                Found in core/Command/L10n/CreateJs.php - About 35 mins to fix

                  Method copyTable has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      protected function copyTable(Connection $fromDB, Connection $toDB, Table $table, InputInterface $input, OutputInterface $output) {
                  Severity: Minor
                  Found in core/Command/Db/ConvertType.php - About 35 mins to fix

                    Method syncMultipleUsers has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            InputInterface $input,
        OutputInterface $output,
        SyncService $syncService,
        UserInterface $backend,
        $missingAccountsAction
                    Severity: Minor
                    Found in core/Command/User/SyncBackend.php - About 35 mins to fix

                      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              IUserManager $userManager,
        IConfig $config,
        ITimeFactory $timeFactory,
        EnvironmentHelper $environmentHelper,
        LostController $lostController
                      Severity: Minor
                      Found in core/Command/User/ResetPassword.php - About 35 mins to fix

                        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                $appName,
        IRequest $request,
        IDBConnection $dbConnection,
        IUserSession $userSession,
        IUserManager $userManager
                        Severity: Minor
                        Found in core/Controller/OcsController.php - About 35 mins to fix

                          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  $appName,
        IRequest $request,
        IConfig $config,
        Application $console,
        ILogger $logger
                          Severity: Minor
                          Found in core/Controller/OccController.php - About 35 mins to fix

                            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    $appName,
        IRequest $request,
        IConfig $config,
        ILogger $logger,
        IJobList $jobList
                            Severity: Minor
                            Found in core/Controller/CronController.php - About 35 mins to fix

                              Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      Manager $twoFactorManager,
        IUserSession $session,
        IURLGenerator $urlGenerator,
        IControllerMethodReflector $reflector,
        IRequest $request
                              Severity: Minor
                              Found in core/Middleware/TwoFactorMiddleware.php - About 35 mins to fix

                                Method tryLogin has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    public function tryLogin($user, $password, $redirect_url, $timezone = null, $remember_login = null) {
                                Severity: Minor
                                Found in core/Controller/LoginController.php - About 35 mins to fix

                                  Similar blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                                          } else if (status === 423) {
                            OC.Notification.show(t('files', 'Could not move "{file}" because either the file or the target are locked.',
                                {file: fileName, message: result.message}), {type: 'error'}
                            );
                        } else if (status === 507) {
                                  Severity: Minor
                                  Found in apps/files/js/filelist.js and 2 other locations - About 35 mins to fix
                                  apps/files/js/filelist.js on lines 2285..2297
                                  apps/files/js/filelist.js on lines 2289..2297

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 47.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                                          } else if (status === 507) {
                            OC.Notification.show(t('files', 'Not enough free space',
                                {file: fileName, message: result.message}), {type: 'error'}
                            );
                        } else if (result != null && typeof result.message !== "undefined") {
                                  Severity: Minor
                                  Found in apps/files/js/filelist.js and 2 other locations - About 35 mins to fix
                                  apps/files/js/filelist.js on lines 2281..2297
                                  apps/files/js/filelist.js on lines 2289..2297

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 47.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                                          } else if (result != null && typeof result.message !== "undefined") {
                            OC.Notification.show(t('files', 'Could not move "{file}": {message}',
                                {file: fileName, message: result.message}), {type: 'error'}
                            );
                        } else {
                                  Severity: Minor
                                  Found in apps/files/js/filelist.js and 2 other locations - About 35 mins to fix
                                  apps/files/js/filelist.js on lines 2281..2297
                                  apps/files/js/filelist.js on lines 2285..2297

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 47.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                      var queueElement = {
                        funcName: $.proxy(self.getMountStatusForMount, self),
                        funcArgs: [value,
                            $.proxy(self.processMountStatusIndividual, self)]
                    };
                                  Severity: Minor
                                  Found in apps/files_external/js/statusmanager.js and 1 other location - About 35 mins to fix
                                  apps/files_external/js/statusmanager.js on lines 334..338

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 47.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language