owncloud/core

View on GitHub

Showing 4,504 of 4,504 total issues

Method getMessageForLicense has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getMessageForLicense(array $info, string $language = null): array {
        $l = $this->l10nFactory->get('core', $language);

        // check if present
        if ($info['licenseState'] === ILicenseManager::LICENSE_STATE_MISSING) {
Severity: Major
Found in lib/private/License/MessageService.php - About 3 hrs to fix

    SMB has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class SMB extends StorageAdapter {
        /** @var bool */
        protected $logActive;
    
        /**
    Severity: Minor
    Found in apps/files_external/lib/Lib/Storage/SMB.php - About 3 hrs to fix

      ObjectStoreStorage has 31 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class ObjectStoreStorage extends \OC\Files\Storage\Common {
          /**
           * @var array
           */
          private static $tmpFiles = [];
      Severity: Minor
      Found in lib/private/Files/ObjectStore/ObjectStoreStorage.php - About 3 hrs to fix

        DefaultShareProvider has 31 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class DefaultShareProvider implements IShareProvider {
            // Special share type for user modified group shares
            public const SHARE_TYPE_USERGROUP = 2;
        
            /** @var IDBConnection */
        Severity: Minor
        Found in lib/private/Share20/DefaultShareProvider.php - About 3 hrs to fix

          RemoteUser has 31 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class RemoteUser implements IUser {
              /** @var string */
              private $userId;
          
              /**
          Severity: Minor
          Found in lib/private/User/RemoteUser.php - About 3 hrs to fix

            DeletedUser has 31 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class DeletedUser implements IUser {
                /** @var Emitter */
                private $emitter;
                /** @var IConfig */
                private $config;
            Severity: Minor
            Found in lib/private/User/DeletedUser.php - About 3 hrs to fix

              File share.js has 326 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              /* global escapeHTML */
              
              /**
               * @namespace
               */
              Severity: Minor
              Found in core/js/share.js - About 3 hrs to fix

                Function _handlePublicLinkQuickAction has 95 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        _handlePublicLinkQuickAction: function(fileInfoModel, shareTab, shareConfig) {
                            var self = this;
                            var shareDialog = shareTab._dialog;
                            var linkShareView;
                            var initNewShareLinkView = true;
                Severity: Major
                Found in apps/files_sharing/js/share.js - About 3 hrs to fix

                  Method createShare has 95 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function createShare(
                          $shareWith,
                          $name,
                          $description,
                          $providerId,
                  Severity: Major
                  Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 3 hrs to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        var TEMPLATE_VERSION =
                            '<li data-revision="{{versionId}}">' +
                            '<div>' +
                            '<div class="preview-container">' +
                            '<img class="preview" src="{{previewUrl}}"/>' +
                    Severity: Major
                    Found in apps/files_versions/js/versionstabview.js and 1 other location - About 3 hrs to fix
                    apps/files_versions/js/versionstabview.js on lines 27..54

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 111.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        var TEMPLATE_CURRENT =
                            '<li data-revision="{{versionId}}" class="current-version">' +
                            '<div>' +
                            '<div class="preview-container">' +
                            '<img class="preview" src="{{previewUrl}}"/>' +
                    Severity: Major
                    Found in apps/files_versions/js/versionstabview.js and 1 other location - About 3 hrs to fix
                    apps/files_versions/js/versionstabview.js on lines 56..83

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 111.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    File mk.js has 324 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    OC.L10N.register(
                        "settings",
                        {
                        "Wrong current password" : "Погрешна лозинка",
                        "The new password cannot be the same as the previous one" : "Новата лозинка неможе да биде иста со старата лозинка",
                    Severity: Minor
                    Found in settings/l10n/mk.js - About 3 hrs to fix

                      File fi_FI.js has 324 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      OC.L10N.register(
                          "core",
                          {
                          "Please select a file." : "Valitse tiedosto.",
                          "File is too big" : "Tiedosto on liian suuri",
                      Severity: Minor
                      Found in core/l10n/fi_FI.js - About 3 hrs to fix

                        Method getShares has 94 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function getShares() {
                                if (!$this->shareManager->shareApiEnabled()) {
                                    return new Result();
                                }
                        
                        
                        Severity: Major
                        Found in apps/files_sharing/lib/Controller/Share20OcsController.php - About 3 hrs to fix

                          Method postAvatar has 94 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function postAvatar($path) {
                                  $userId = $this->userSession->getUser()->getUID();
                                  $files = $this->request->getUploadedFile('files');
                                  $tmpImage = null;
                          
                          
                          Severity: Major
                          Found in core/Controller/AvatarController.php - About 3 hrs to fix

                            Function appSettings has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                            Open

                                appSettings: function (args) {
                                    if (typeof args === 'undefined' || typeof args.appid === 'undefined') {
                                        throw {name: 'MissingParameter', message: 'The parameter appid is missing'};
                                    }
                                    var props = {scriptName: 'settings.php', cache: true};
                            Severity: Minor
                            Found in core/js/js.js - About 3 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function buildSuperShares has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                            Open

                                private function buildSuperShares(array $allShares, \OCP\IUser $user) {
                                    $result = [];
                            
                                    $groupedShares = $this->groupShares($allShares);
                            
                            
                            Severity: Minor
                            Found in apps/files_sharing/lib/MountProvider.php - About 3 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function mapperEvent has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function mapperEvent(MapperEvent $event) {
                                    $tagIds = $event->getTags();
                                    if ($event->getObjectType() !== 'files' ||empty($tagIds)
                                        || !\in_array($event->getEvent(), [MapperEvent::EVENT_ASSIGN, MapperEvent::EVENT_UNASSIGN])
                                        || !$this->appManager->isInstalled('activity')) {
                            Severity: Minor
                            Found in apps/systemtags/lib/Activity/Listener.php - About 3 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function collectUsersShares has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                            Open

                                private function collectUsersShares(InputInterface $input, OutputInterface $output) {
                                    $output->writeln("Collecting all share information for files and folder of $this->sourceUser ...");
                            
                                    $skipped = 0;
                                    $progress = new ProgressBar($output, \count($this->shares));
                            Severity: Minor
                            Found in apps/files/lib/Command/TransferOwnership.php - About 3 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function handleRequest has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public static function handleRequest() {
                                    \OC::$server->getEventLogger()->start('handle_request', 'Handle request');
                                    $systemConfig = \OC::$server->getSystemConfig();
                                    // load all the classpaths from the enabled apps so they are available
                                    // in the routing files of each app
                            Severity: Minor
                            Found in lib/kernel.php - About 3 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language