Method `findInvalidReshareInitiator` has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function findInvalidReshareInitiator(InputInterface $input, OutputInterface $output, $fix, $scopeUid) {
        $output->writeln([
            "<info>==========================</info>",
            "<info>Searching for reshares that have invalid uid_initiator(resharer), meaning resharer which does not have the received share mounted anymore (that he reshared with other user).</info>",
            "<info>==========================</info>",

Found in apps/files/lib/Command/TroubleshootTransferOwnership.php - About 2 hrs to fix

Method `validatePermissions` has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function validatePermissions(IShare $share) {
        // Permissions should be set
        if ($share->getPermissions() === null) {
            throw new \InvalidArgumentException('A share requires permissions');
        }

Found in lib/private/Share20/Manager.php - About 2 hrs to fix

Method `installApp` has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function installApp($data = []) {
        $l = \OC::$server->getL10N('lib');

        list($extractDir, $path) = self::downloadApp($data);

Found in lib/private/Installer.php - About 2 hrs to fix

Method `fixOrientation` has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fixOrientation() {
        $o = $this->getOrientation();
        $this->logger->debug('OC_Image->fixOrientation() Orientation: ' . $o, ['app' => 'core']);
        $rotate = 0;
        $flip = false;

Found in lib/private/legacy/image.php - About 2 hrs to fix

Method `execute` has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output): int {
        $outputType = $input->getOption('output');

        \OC_App::loadApps();
        $this->router->loadRoutes();

Found in core/Command/Security/ListRoutes.php - About 2 hrs to fix

Method `execute` has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output): int {
        $appNameSubString = $input->getArgument('search-pattern');
        $minimalView = $input->getOption('minimal');

        if ($input->getOption('shipped') === 'true' || $input->getOption('shipped') === 'false') {

Found in core/Command/App/ListApps.php - About 2 hrs to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function getLength() {
        $req = $this->server->httpRequest;
        $length = $req->getHeader('X-Expected-Entity-Length');
        if (!\is_numeric($length)) {
            $length = $req->getHeader('Content-Length');

Found in apps/dav/lib/Connector/Sabre/QuotaPlugin.php and 1 other location - About 2 hrs to fix

Read up
Read up

apps/dav/lib/Files/PublicFiles/PublicFilesPlugin.php on lines 279..293

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 130.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 130.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 130.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 130.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.