owncloud/core

OC_Helper has 22 functions (exceeds 20 allowed). Consider refactoring.

Open

class OC_Helper {
    private static $templateManager;

    /**
     * Creates an absolute url for public use

MigrationService has 22 functions (exceeds 20 allowed). Consider refactoring.

Open

class MigrationService {
    /** @var boolean */
    private $migrationTableCreated;
    /** @var array */
    private $migrations;

AllConfig has 22 functions (exceeds 20 allowed). Consider refactoring.

Open

class AllConfig implements IConfig {
    /** @var SystemConfig */
    private $systemConfig;

    /** @var IDBConnection */

Manager has 22 functions (exceeds 20 allowed). Consider refactoring.

Open

class Manager extends PublicEmitter implements IUserManager {
    use EventEmitterTrait;
    /** @var UserInterface[] $backends */
    private $backends = [];

Function filter has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    filter: function(query) {
        // FIXME: the caller doesn't properly set the "this" context
        var self = OC.Settings.Apps;
        self._filterQuery = query;

Method create has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function create(\OCP\Share\IShare $share) {
        $this->validate($share);
        $qb = $this->dbConn->getQueryBuilder();

        $qb->insert('share');

Method getStorageInfo has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static function getStorageInfo($path, $rootInfo = null) {
        // return storage info without adding mount points
        $includeExtStorage = \OC::$server->getSystemConfig()->getValue('quota_include_external_storage', false);

        if (!$rootInfo) {

Method saveColumn has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private static function saveColumn($column, $xml) {
        $xml->addChild('name', $column->getName());
        switch ($column->getType()) {
            case 'SmallInt':
            case 'Integer':

Method auth has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function auth(IRequest $request) {
        if (!isset($request->server['PHP_AUTH_USER'], $request->server['PHP_AUTH_PW'])) {
            return null;
        }
        if ($this->session->exists('app_password')) {

Method configure has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function configure() {
        parent::configure();
        $this
            ->setName('user:setting')
            ->setDescription('Read and modify user settings.')

File Notifications.php has 263 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/**
 * @author Björn Schießle <bjoern@schiessle.org>
 * @author Joas Schilling <coding@schilljs.com>
 * @author Lukas Reschke <lukas@statuscode.ch>

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                for (var i = 0; i < files.length; i++) {
                    var deleteAction = this.findFileEl(files[i]).children("td.date").children(".action.delete");
                    deleteAction.removeClass('icon-delete').addClass('icon-loading-small');
                }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                for (var i = 0; i < files.length; i++) {
                    var deleteAction = this.findFileEl(files[i]).children("td.date").children(".action.delete");
                    deleteAction.removeClass('icon-delete').addClass('icon-loading-small');
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    var TEMPLATE_AUTOCOMPLETE_ITEM =
        '<li class="{{shareTypeClass}}">' +
            '<a>' +
                '<div class="share-autocomplete-item">' +
                    '{{#if showAvatar}}' +

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    var TEMPLATE =
        '<div class="thumbnailContainer"><a href="#" class="thumbnail action-default"><div class="stretcher"/></a></div>' +
        '<div class="file-details-container">' +
        '<div class="fileName">' +
            '<h3 title="{{name}}" class="ellipsis">{{name}}</h3>' +

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            fileList._getWebdavProperties = function() {
                var props = oldGetWebdavProperties.apply(this, arguments);
                props.push(OC.Files.Client.PROPERTY_TAGS);
                props.push(OC.Files.Client.PROPERTY_FAVORITE);
                return props;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            fileList._getWebdavProperties = function() {
                var props = oldGetWebdavProperties.apply(this, arguments);
                props.push(OC.Files.Client.PROPERTY_OWNER_DISPLAY_NAME);
                props.push(OC.Files.Client.PROPERTY_SHARE_TYPES);
                return props;

• Read up
  Read up

Function RollingQueue has 57 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var RollingQueue = function (functionList, queueWindow, callback) {
    this.queueWindow = queueWindow || 1;
    this.functionList = functionList;
    this.callback = callback;
    this.counter = 0;

Method translateLong has 57 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function translateLong($text, IL10N $l, array $params) {
        switch ($text) {
            case self::SUBJECT_REMOTE_SHARE_RECEIVED:
                if (\sizeof($params) > 1) {
                    // New activity ownCloud 8.2+

Method updateShareState has 57 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function updateShareState($id, $state) {
        $eventName = '';
        if ($state === Share::STATE_ACCEPTED) {
            $eventName = 'accept';
        } elseif ($state === Share::STATE_REJECTED) {