owncloud/core

View on GitHub

Showing 3,235 of 4,504 total issues

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        Manager $twoFactorManager,
        IUserSession $session,
        IURLGenerator $urlGenerator,
        IControllerMethodReflector $reflector,
        IRequest $request
Severity: Minor
Found in core/Middleware/TwoFactorMiddleware.php - About 35 mins to fix

    Method tryLogin has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function tryLogin($user, $password, $redirect_url, $timezone = null, $remember_login = null) {
    Severity: Minor
    Found in core/Controller/LoginController.php - About 35 mins to fix

      Function loadCategory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          loadCategory: function(categoryId) {
              var self = this;
              if (OC.Settings.Apps.State.currentCategory === categoryId) {
                  return;
              }
      Severity: Minor
      Found in settings/js/admin-apps.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function filter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          filter: function(query) {
              // FIXME: the caller doesn't properly set the "this" context
              var self = OC.Settings.Apps;
              self._filterQuery = query;
      
      
      Severity: Minor
      Found in settings/js/admin-apps.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ensureFolderExists has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          ensureFolderExists: function(fullPath) {
              if (!fullPath || fullPath === '/') {
                  return $.Deferred().resolve().promise();
              }
      
      
      Severity: Minor
      Found in apps/files/js/file-upload.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function registerXHRForErrorProcessing has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          registerXHRForErrorProcessing: function (xhr) {
              var loadCallback = function () {
                  if (xhr.readyState !== 4) {
                      return;
                  }
      Severity: Minor
      Found in core/js/js.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function humanFileSize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function humanFileSize(size, skipSmallSizes) {
          var humanList = ['B', 'KB', 'MB', 'GB', 'TB'];
          // Calculate Log with base 1024: size = 1024 ** order
          var order = size > 0 ? Math.floor(Math.log(size) / Math.log(1024)) : 0;
          // Stay in range of the byte sizes that are defined
      Severity: Minor
      Found in core/js/js.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _pushState has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          _pushState: function (params, replace) {
              var strParams;
              if (typeof(params) === 'string') {
                  strParams = params;
              }
      Severity: Minor
      Found in core/js/js.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function naturalSortCompare has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          naturalSortCompare: function (a, b) {
              var x;
              var aa = OC.Util._chunkify(a);
              var bb = OC.Util._chunkify(b);
      
      
      Severity: Minor
      Found in core/js/js.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _onPopState has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          _onPopState: function (e) {
              if (this._cancelPop) {
                  this._cancelPop = false;
                  return;
              }
      Severity: Minor
      Found in core/js/js.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addScript has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          addScript: function (app, script, ready) {
              var deferred, path = OC.filePath(app, 'js', script + '.js');
              if (!OC.addScript.loaded[path]) {
                  if (ready) {
                      deferred = $.getScript(path, ready);
      Severity: Minor
      Found in core/js/js.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function sendLinkDone has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          sendLinkDone : function(result){
              var sendErrorMsg;
      
              if (result && result.status === 'success'){
                  OC.Lostpassword.sendLinkSuccess();
      Severity: Minor
      Found in core/js/lostpassword.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _generatePluralFunction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          _generatePluralFunction: function(pluralForm) {
              // default func
              var func = function (n) {
                  var p = (n !== 1) ? 1 : 0;
                  return { 'nplural' : 2, 'plural' : p };
      Severity: Minor
      Found in core/js/l10n.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function resendInvitation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function resendInvitation($userId) {
              $user = $this->userManager->get($userId);
              $currentUser = $this->userSession->getUser();
      
              if ($user === null || $this->userTypeHelper->isGuestUser($userId) === true) {
      Severity: Minor
      Found in settings/Controller/UsersController.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setDisplayName has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setDisplayName($username, $displayName) {
              $resp = $this->validateString($displayName, 64);
              if ($resp) {
                  return $resp;
              }
      Severity: Minor
      Found in settings/Controller/UsersController.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function changeSchema has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function changeSchema(Schema $schema, array $options) {
              $prefix = $options['tablePrefix'];
      
              if ($schema->hasTable("{$prefix}share_external")) {
                  $table = $schema->getTable("{$prefix}share_external");
      Severity: Minor
      Found in apps/files_sharing/appinfo/Migrations/Version20170804201253.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function run($argument) {
              $enabled = $this->config->getAppValue('files_sharing', 'cronjob_scan_external_enabled', 'no');
              if ($enabled !== 'yes') {
                  $this->logger->debug(
                      "Fed share scanner disabled, ignoring the run"
      Severity: Minor
      Found in apps/files_sharing/lib/External/ScanExternalSharesJob.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getPanel has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getPanel() {
              $tmpl = new Template('files_sharing', 'settings-personal');
              $enabledConfigs = [];
              foreach (self::USER_CONFIGS as $config) {
                  if ($config['key'] === 'auto_accept_share') {
      Severity: Minor
      Found in apps/files_sharing/lib/Panels/Personal/PersonalPanel.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function generateTarget has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function generateTarget($filePath, $shareWith, $exclude = null) {
              $shareFolder = \OCA\Files_Sharing\Helper::getShareFolder();
              $target = \OC\Files\Filesystem::normalizePath($shareFolder . '/' . \basename($filePath));
      
              // for group shares we return the target right away
      Severity: Minor
      Found in apps/files_sharing/lib/ShareBackend/File.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getShare has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getShare($id) {
              if (!$this->shareManager->shareApiEnabled()) {
                  return new Result(null, 404, $this->l->t('Share API is disabled'));
              }
      
      
      Severity: Minor
      Found in apps/files_sharing/lib/Controller/Share20OcsController.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language