owncloud/core

View on GitHub

Showing 3,235 of 4,503 total issues

File share.js has 326 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* global escapeHTML */

/**
 * @namespace
 */
Severity: Minor
Found in core/js/share.js - About 3 hrs to fix

    Function _handlePublicLinkQuickAction has 95 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _handlePublicLinkQuickAction: function(fileInfoModel, shareTab, shareConfig) {
                var self = this;
                var shareDialog = shareTab._dialog;
                var linkShareView;
                var initNewShareLinkView = true;
    Severity: Major
    Found in apps/files_sharing/js/share.js - About 3 hrs to fix

      Method createShare has 95 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createShare(
              $shareWith,
              $name,
              $description,
              $providerId,
      Severity: Major
      Found in apps/federatedfilesharing/lib/Controller/OcmController.php - About 3 hrs to fix

        File mk.js has 324 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        OC.L10N.register(
            "settings",
            {
            "Wrong current password" : "Погрешна лозинка",
            "The new password cannot be the same as the previous one" : "Новата лозинка неможе да биде иста со старата лозинка",
        Severity: Minor
        Found in settings/l10n/mk.js - About 3 hrs to fix

          File fi_FI.js has 324 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          OC.L10N.register(
              "core",
              {
              "Please select a file." : "Valitse tiedosto.",
              "File is too big" : "Tiedosto on liian suuri",
          Severity: Minor
          Found in core/l10n/fi_FI.js - About 3 hrs to fix

            Method getShares has 94 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getShares() {
                    if (!$this->shareManager->shareApiEnabled()) {
                        return new Result();
                    }
            
            
            Severity: Major
            Found in apps/files_sharing/lib/Controller/Share20OcsController.php - About 3 hrs to fix

              Method postAvatar has 94 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function postAvatar($path) {
                      $userId = $this->userSession->getUser()->getUID();
                      $files = $this->request->getUploadedFile('files');
                      $tmpImage = null;
              
              
              Severity: Major
              Found in core/Controller/AvatarController.php - About 3 hrs to fix

                Function appSettings has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    appSettings: function (args) {
                        if (typeof args === 'undefined' || typeof args.appid === 'undefined') {
                            throw {name: 'MissingParameter', message: 'The parameter appid is missing'};
                        }
                        var props = {scriptName: 'settings.php', cache: true};
                Severity: Minor
                Found in core/js/js.js - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function buildSuperShares has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function buildSuperShares(array $allShares, \OCP\IUser $user) {
                        $result = [];
                
                        $groupedShares = $this->groupShares($allShares);
                
                
                Severity: Minor
                Found in apps/files_sharing/lib/MountProvider.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function mapperEvent has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function mapperEvent(MapperEvent $event) {
                        $tagIds = $event->getTags();
                        if ($event->getObjectType() !== 'files' ||empty($tagIds)
                            || !\in_array($event->getEvent(), [MapperEvent::EVENT_ASSIGN, MapperEvent::EVENT_UNASSIGN])
                            || !$this->appManager->isInstalled('activity')) {
                Severity: Minor
                Found in apps/systemtags/lib/Activity/Listener.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function collectUsersShares has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function collectUsersShares(InputInterface $input, OutputInterface $output) {
                        $output->writeln("Collecting all share information for files and folder of $this->sourceUser ...");
                
                        $skipped = 0;
                        $progress = new ProgressBar($output, \count($this->shares));
                Severity: Minor
                Found in apps/files/lib/Command/TransferOwnership.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function handleRequest has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function handleRequest() {
                        \OC::$server->getEventLogger()->start('handle_request', 'Handle request');
                        $systemConfig = \OC::$server->getSystemConfig();
                        // load all the classpaths from the enabled apps so they are available
                        // in the routing files of each app
                Severity: Minor
                Found in lib/kernel.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getItemSharedWithUser has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function getItemSharedWithUser($itemType, $itemSource, $user, $owner = null, $shareType = null) {
                        $shares = [];
                        $fileDependent = false;
                
                        $where = 'WHERE';
                Severity: Minor
                Found in lib/private/Share/Share.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function parseHttpRangeHeader has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    private static function parseHttpRangeHeader($rangeHeaderPos, $fileSize) {
                        $rArray=\explode(',', $rangeHeaderPos);
                        $minOffset = 0;
                        $ind = 0;
                
                
                Severity: Minor
                Found in lib/private/legacy/files.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function checkAppsIntegrity has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function checkAppsIntegrity($data, $extractDir, $path, $isShipped = false) {
                        $l = \OC::$server->getL10N('lib');
                        //load the info.xml file of the app
                        if (!\is_file($extractDir.'/appinfo/info.xml')) {
                            //try to find it in a subdir
                Severity: Minor
                Found in lib/private/Installer.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function get has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function get($dir, $files, $params = null) {
                        $view = \OC\Files\Filesystem::getView();
                
                        if (!\is_array($files)) {
                            // "files" contains a string with a filename
                Severity: Minor
                Found in lib/private/legacy/files.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function xmlToArray has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function xmlToArray($xml) {
                        if (!$xml->children()) {
                            return (string)$xml;
                        }
                
                
                Severity: Minor
                Found in lib/private/App/InfoParser.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _output has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function _output($filePath = null, $mimeType = null) {
                        if ($filePath) {
                            if (!\file_exists(\dirname($filePath))) {
                                \mkdir(\dirname($filePath), 0777, true);
                            }
                Severity: Minor
                Found in lib/private/legacy/image.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function postAvatar has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function postAvatar($path) {
                        $userId = $this->userSession->getUser()->getUID();
                        $files = $this->request->getUploadedFile('files');
                        $tmpImage = null;
                
                
                Severity: Minor
                Found in core/Controller/AvatarController.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File sharedialoglinkshareview.js has 322 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                /*
                 * Copyright (c) 2015
                 *
                 * This file is licensed under the Affero General Public License version 3
                 * or later.
                Severity: Minor
                Found in core/js/sharedialoglinkshareview.js - About 3 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language