owncloud/core

View on GitHub

Showing 3,235 of 4,503 total issues

File QueryBuilder.php has 322 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @author Joas Schilling <coding@schilljs.com>
 * @author Robin Appelman <icewind@owncloud.com>
 * @author Thomas Müller <thomas.mueller@tmit.eu>
Severity: Minor
Found in lib/private/DB/QueryBuilder/QueryBuilder.php - About 3 hrs to fix

    Method createFileChunked has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function createFileChunked($data) {
            list($path, $name) = \Sabre\Uri\split($this->path);
    
            $info = \OC_FileChunking::decodeName($name);
            if (empty($info)) {
    Severity: Major
    Found in apps/dav/lib/Connector/Sabre/File.php - About 3 hrs to fix

      Method showLoginForm has 93 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function showLoginForm($user, $redirect_url, $remember_login) {
              // check if there is apache auth backend available and try to obtain session,
              // if apache backend not registered or failed to login, proceed with show login form
              if ($this->handleApacheAuth()) {
                  // apache auth was completed server-side and there is active session,
      Severity: Major
      Found in core/Controller/LoginController.php - About 3 hrs to fix

        File search.js has 321 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /**
         * ownCloud - core
         *
         * This file is licensed under the Affero General Public License version 3 or
         * later. See the COPYING file.
        Severity: Minor
        Found in core/search/js/search.js - About 3 hrs to fix

          File pt_PT.js has 320 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          OC.L10N.register(
              "settings",
              {
              "No user supplied" : "Nenhum utilizador especificado",
              "Authentication error" : "Erro de autenticação",
          Severity: Minor
          Found in settings/l10n/pt_PT.js - About 3 hrs to fix

            Function _triggerGroupEdit has 92 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                _triggerGroupEdit: function($td, isSubadminSelect) {
                    var $groupsListContainer = $td.find('.groupsListContainer');
                    var placeholder = $groupsListContainer.attr('data-placeholder') || t('settings', 'no group');
                    var user = UserList.getUID($td);
                    var checked = _.keys($td.data('groups')) || [];
            Severity: Major
            Found in settings/js/users/users.js - About 3 hrs to fix

              File pt_PT.js has 320 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              OC.L10N.register(
                  "core",
                  {
                  "Please select a file." : "Por favor, selecione um ficheiro.",
                  "File is too big" : "O ficheiro é demasiado grande",
              Severity: Minor
              Found in core/l10n/pt_PT.js - About 3 hrs to fix

                Method setMailAddress has 92 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function setMailAddress($id, $mailAddress) {
                        $userId = $this->userSession->getUser()->getUID();
                        $user = $this->userManager->get($id);
                
                        if ($userId !== $id
                Severity: Major
                Found in settings/Controller/UsersController.php - About 3 hrs to fix

                  Method getCapabilities has 92 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getCapabilities() {
                          $res = [];
                  
                          if ($this->config->getAppValue('core', 'shareapi_enabled', 'yes') !== 'yes') {
                              $res['api_enabled'] = false;
                  Severity: Major
                  Found in apps/files_sharing/lib/Capabilities.php - About 3 hrs to fix

                    Method scanFile has 92 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function scanFile($file, $reuseExisting = 0, $parentId = -1, $cacheData = null, $lock = true) {
                            // only proceed if $file is not a partial file nor a blacklisted file
                            if (!self::isPartialFile($file) and !Filesystem::isFileBlacklisted($file)) {
                                //acquire a lock
                                if ($lock && $this->storage->instanceOfStorage(ILockingStorage::class)) {
                    Severity: Major
                    Found in lib/private/Files/Cache/Scanner.php - About 3 hrs to fix

                      CardDavBackend has 30 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class CardDavBackend implements BackendInterface, SyncSupport {
                          /** @var Principal */
                          private $principalBackend;
                      
                          /** @var string */
                      Severity: Minor
                      Found in apps/dav/lib/CardDAV/CardDavBackend.php - About 3 hrs to fix

                        Google has 30 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        class Google extends \OCP\Files\Storage\StorageAdapter {
                            private $client;
                            private $id;
                            private $root;
                            private $service;
                        Severity: Minor
                        Found in apps/files_external/lib/Lib/Storage/Google.php - About 3 hrs to fix

                          File groups.js has 319 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          /**
                           * Copyright (c) 2014, Raghu Nayyar <beingminimal@gmail.com>
                           * Copyright (c) 2014, Arthur Schiwon <blizzz@owncloud.com>
                           * This file is licensed under the Affero General Public License version 3 or later.
                           * See the COPYING-README file.
                          Severity: Minor
                          Found in settings/js/users/groups.js - About 3 hrs to fix

                            File sl.js has 319 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            OC.L10N.register(
                                "core",
                                {
                                "Please select a file." : "Izberite datoteko",
                                "File is too big" : "Datoteka je prevelika",
                            Severity: Minor
                            Found in core/l10n/sl.js - About 3 hrs to fix

                              File Activity.php has 319 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              <?php
                              /**
                               * @author Björn Schießle <bjoern@schiessle.org>
                               * @author Joas Schilling <coding@schilljs.com>
                               * @author Morris Jobke <hey@morrisjobke.de>
                              Severity: Minor
                              Found in apps/files_sharing/lib/Activity.php - About 3 hrs to fix

                                File Scanner.php has 319 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                <?php
                                /**
                                 * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
                                 * @author Björn Schießle <bjoern@schiessle.org>
                                 * @author Daniel Jagszent <daniel@jagszent.de>
                                Severity: Minor
                                Found in lib/private/Files/Cache/Scanner.php - About 3 hrs to fix

                                  Method getUsers has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      protected function getUsers($search) {
                                          $this->result['users'] = $this->result['exact']['users'] = $users = [];
                                  
                                          if (\strlen(\trim($search)) === 0 && $this->userSearch->getSearchMinLength() > 0) {
                                              $this->result['users'] = [];
                                  Severity: Major
                                  Found in apps/files_sharing/lib/Controller/ShareesController.php - About 3 hrs to fix

                                    Method createServer has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        public function createServer(
                                            $baseUri,
                                            $requestUri,
                                            BackendInterface $authBackend,
                                            callable $viewCallBack,
                                    Severity: Major
                                    Found in apps/dav/lib/Connector/Sabre/ServerFactory.php - About 3 hrs to fix

                                      Method handleRequest has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                          public static function handleRequest() {
                                              \OC::$server->getEventLogger()->start('handle_request', 'Handle request');
                                              $systemConfig = \OC::$server->getSystemConfig();
                                              // load all the classpaths from the enabled apps so they are available
                                              // in the routing files of each app
                                      Severity: Major
                                      Found in lib/kernel.php - About 3 hrs to fix

                                        File da.js has 317 lines of code (exceeds 250 allowed). Consider refactoring.
                                        Open

                                        OC.L10N.register(
                                            "settings",
                                            {
                                            "No user supplied" : "Intet brugernavn givet",
                                            "Authentication error" : "Adgangsfejl",
                                        Severity: Minor
                                        Found in settings/l10n/da.js - About 3 hrs to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language