owncloud/core

View on GitHub

Showing 3,235 of 4,504 total issues

Function start has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        start: function($el, options) {
            if (this._started) {
                return;
            }

Severity: Major
Found in core/js/update.js - About 3 hrs to fix

    Method createShare has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createShare() {
            try {
                $this->ocmMiddleware->assertIncomingSharingEnabled();
                $remote = $this->request->getParam('remote', null);
                $token = $this->request->getParam('token', null);
    Severity: Major
    Found in apps/federatedfilesharing/lib/Controller/RequestHandlerController.php - About 3 hrs to fix

      File Directory.php has 295 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      /**
       * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
       * @author Bart Visscher <bartv@thisnet.nl>
       * @author Björn Schießle <bjoern@schiessle.org>
      Severity: Minor
      Found in apps/dav/lib/Connector/Sabre/Directory.php - About 3 hrs to fix

        File fi_FI.js has 294 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        OC.L10N.register(
            "settings",
            {
            "No user supplied" : "Käyttäjää ei määritetty",
            "Authentication error" : "Tunnistautumisvirhe",
        Severity: Minor
        Found in settings/l10n/fi_FI.js - About 3 hrs to fix

          Function _promptFileName has 76 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  _promptFileName: function($target) {
                      var self = this;
                      if (!OCA.Files.NewFileMenu._TEMPLATE_FORM) {
                          OCA.Files.NewFileMenu._TEMPLATE_FORM = Handlebars.compile(TEMPLATE_FILENAME_FORM);
                      }
          Severity: Major
          Found in apps/files/js/newfilemenu.js - About 3 hrs to fix

            Function _onSend has 76 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    _onSend: function (e, data) {
                        if (!data.submit) {
                            this._addConvenienceMethods(e, data);
                        }
                        var that = this,
            Severity: Major
            Found in apps/files/js/jquery.fileupload.js - About 3 hrs to fix

              File MailNotifications.php has 293 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              /**
               * @author Björn Schießle <bjoern@schiessle.org>
               * @author Joas Schilling <coding@schilljs.com>
               * @author Lukas Reschke <lukas@statuscode.ch>
              Severity: Minor
              Found in lib/private/Share/MailNotifications.php - About 3 hrs to fix

                File app.js has 292 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                /*
                 * Copyright (c) 2014 Vincent Petry <pvince81@owncloud.com>
                 *
                 * This file is licensed under the Affero General Public License version 3
                 * or later.
                Severity: Minor
                Found in apps/files_sharing/js/app.js - About 3 hrs to fix

                  Method getFileInfo has 75 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function getFileInfo($path) {
                          $this->log('enter: '.__FUNCTION__."($path)");
                          $path = $this->buildPath($path);
                          if (!isset($this->statCache[$path])) {
                              try {
                  Severity: Major
                  Found in apps/files_external/lib/Lib/Storage/SMB.php - About 3 hrs to fix

                    Share has 26 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class Share extends \OC\Share\Constants {
                        /**
                         * Register a sharing backend class that implements OCP\Share_Backend for an item type
                         * @param string $itemType Item type
                         * @param string $class Backend class
                    Severity: Minor
                    Found in lib/public/Share.php - About 3 hrs to fix

                      CacheJail has 26 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class CacheJail extends CacheWrapper {
                          /**
                           * @var string
                           */
                          protected $root;
                      Severity: Minor
                      Found in lib/private/Files/Cache/Wrapper/CacheJail.php - About 3 hrs to fix

                        Tags has 26 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        class Tags implements \OCP\ITags {
                            /**
                             * Tags
                             *
                             * @var array
                        Severity: Minor
                        Found in lib/private/Tags.php - About 3 hrs to fix

                          Manager has 26 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          class Manager implements IManager {
                              /** @var IRequest */
                              protected $request;
                          
                              /** @var IUserSession */
                          Severity: Minor
                          Found in lib/private/Activity/Manager.php - About 3 hrs to fix

                            Method changeSchema has 75 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function changeSchema(Schema $schema, array $options) {
                                    $prefix = $options['tablePrefix'];
                                    if (!$schema->hasTable("{$prefix}share")) {
                                        $table = $schema->createTable("{$prefix}share");
                                        $table->addColumn('id', 'integer', [
                            Severity: Major
                            Found in core/Migrations/Version20170315173825.php - About 3 hrs to fix

                              File ast.js has 291 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              OC.L10N.register(
                                  "core",
                                  {
                                  "Please select a file." : "Por favor esbilla un ficheru.",
                                  "File is too big" : "Ficheru ye demasiáu grande",
                              Severity: Minor
                              Found in core/l10n/ast.js - About 3 hrs to fix

                                Function afterCall has 74 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                            var afterCall = function(data, statusText, xhr) {
                                                var messages = [];
                                                if (xhr.status === 200 && data) {
                                                    if (!data.serverHasInternetConnection) {
                                                        messages.push({
                                Severity: Major
                                Found in core/js/setupchecks.js - About 2 hrs to fix

                                  File SFTP.php has 290 lines of code (exceeds 250 allowed). Consider refactoring.
                                  Open

                                  <?php
                                  /**
                                   * @author Andreas Fischer <bantu@owncloud.com>
                                   * @author Bart Visscher <bartv@thisnet.nl>
                                   * @author hkjolhede <hkjolhede@gmail.com>
                                  Severity: Minor
                                  Found in apps/files_external/lib/Lib/Storage/SFTP.php - About 2 hrs to fix

                                    Method basicOperation has 74 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        private function basicOperation($operation, $path, $hooks = [], $extraParam = null) {
                                            $postFix = (\substr($path, -1, 1) === '/') ? '/' : '';
                                            $absolutePath = Filesystem::normalizePath($this->getAbsolutePath($path));
                                            if (Filesystem::isValidPath($path)
                                                and !Filesystem::isForbiddenFileOrDir($path)
                                    Severity: Major
                                    Found in lib/private/Files/View.php - About 2 hrs to fix

                                      Method verify has 74 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                          private function verify($signaturePath, $basePath, $certificateCN, $force = false) {
                                              if (!$force && !$this->isCodeCheckEnforced()) {
                                                  return [];
                                              }
                                      
                                      
                                      Severity: Major
                                      Found in lib/private/IntegrityCheck/Checker.php - About 2 hrs to fix

                                        Method upsert has 74 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                            public function upsert($table, $input, $compare) {
                                                $this->conn->beginTransaction();
                                                $done = false;
                                        
                                                if (empty($compare)) {
                                        Severity: Major
                                        Found in lib/private/DB/Adapter.php - About 2 hrs to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language