Showing 4,482 of 4,482 total issues
Function new has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
public function new(?string $parent_container_id, ?string $filename): DataResponse {
$userAgent = $this->request->getHeader('User-Agent') ?? '-';
$this->logger->info("new($parent_container_id, $filename) - $userAgent");
if ($parent_container_id === null) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getDefaultApp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
private function getDefaultApp(string $mimeType): ?string {
# get mime from file and see which of the enabled apps matches
foreach (self::$apps as $app_name => $app_info) {
$oc_app_name = $app_info['oc_app_name'];
if ($this->appManager->isEnabledForUser($oc_app_name)) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"